Open gilbertocamara opened 1 year ago
Dear @jooolia and @mpadge
Many thanks! Much appreciated!
@ropensci-review-bot seeking reviewers
Please add this badge to the README of your package repository:
[![Status at rOpenSci Software Peer Review](https://badges.ropensci.org/596_status.svg)](https://github.com/ropensci/software-review/issues/596)
Furthermore, if your package does not have a NEWS.md file yet, please create one to capture the changes made during the review process. See https://devguide.ropensci.org/releasing.html#news
Thanks! Included rOpenSci badge in sits github site.
@ropensci-review-bot assign @mikemahoney218 as reviewer
@mikemahoney218 added to the reviewers list. Review due date is 2024-06-28. Thanks @mikemahoney218 for accepting to review! Please refer to our reviewer guide.
rOpenSci’s community is our best asset. We aim for reviews to be open, non-adversarial, and focused on improving software quality. Be respectful and kind! See our reviewers guide and code of conduct for more.
@mikemahoney218: If you haven't done so, please fill this form for us to update our reviewers records.
@ropensci-review-bot assign @paleolimbot as reviewer
@paleolimbot added to the reviewers list. Review due date is 2024-06-28. Thanks @paleolimbot for accepting to review! Please refer to our reviewer guide.
rOpenSci’s community is our best asset. We aim for reviews to be open, non-adversarial, and focused on improving software quality. Be respectful and kind! See our reviewers guide and code of conduct for more.
@paleolimbot: If you haven't done so, please fill this form for us to update our reviewers records.
@ropensci-review-bot set due date for @mikemahoney218 to 2024-08-07
Review due date for @mikemahoney218 is now 07-August-2024
@ropensci-review-bot set due date for @paleolimbot to 2024-08-07
Review due date for @paleolimbot is now 07-August-2024
@gilbertocamara Exctied that we now have two reviewers for your package. Owing to it's large size, review durations have been extended from the usual 3 weeks to 2 months.
Dear @mpadge @paleolimbot @mikemahoney218 Many thanks to @mpadge for motivating two reviewers and to @paleolimbot and @mikemahoney218 for accepting to do it.
May I suggest to @paleolimbot and @mikemahoney218 that they start the software review by browsing the online book (https://e-sensing.github.io/sitsbook/). The book is a self-learning document and takes a step-by-step approach with reproducible code.
Unlike most R packages, which are a collection of mostly independent functions, the sits
API is an end-to-end solution for analysing big Earth observation data. Thus, the functions have to be executed in a well-defined order. Looking at the scripts in the online book will give one a better sense of how the package has been organised.
Again, many thanks to @paleolimbot and @mikemahoney218 for your generosity.
Hi @paleolimbot and @mikemahoney218, just checking in to see how you're going with your reviews that were due at the beginning of this month as the current EIC. Please just let us know if you need some more time so we can update this issue.
Deeply, deeply apologize for how far behind I am on this one. It's now on top of my pile and I should have a review soon. Apologies again for the delay.
Dear @mikemahoney218 many thanks for your time and effort! Please note that sits
is now on version 1.5.2. on CRAN. Before looking at the code, may I suggest you browse the online book that describes the package. Some additional tips that might help you:
(1) sits
differs from most traditional R packages, which are collections of functions that can be used independently.
It is an end-to-end solution for Earth observation (EO) land use and land cover classification. As such, there is a certain preferred order of function execution. Please see the Introduction chapter of the online book for more details.
(2) sits
is more than a collection of machine learning algorithms for EO analytics. Much effort went into providing access to EO cloud collection and organising analysis-ready data (ARD) images into data cubes. In R
, there is nothing similar. Even compared with EO-ML packages in Python, sits
is the only software that allows easy access to cloud collections.
(3) To access EO cloud collections, sits
works together with rstac
, which is the main support in R
for STAC collection access. rstac
has also been developed by our team.
(4) A useful comparison table has been prepared by the Python TorchGEO team. It provides a fair appraisal of the ML capabilities of different EO-ML packages.
(5) As far as we know, the algorithms for SOM-based training data quality control and Bayesian inference for post-processing are only available on sits
.
(6) Much thought and effort went into designing the sits
API. Please see a comparison of the sits
API and that of the Google Earth Engine.
Apologies on my end too! I'll prioritize taking a look at this this week 🙂
Submitting Author Name: Gilberto Camara Submitting Author Github Handle: !--author1-->@gilbertocamara<!--end-author1-- Other Package Authors Github handles: @rolfsimoes, @OldLipe, @pedro-andrade-inpe Repository: https://github.com/e-sensing/sits Version submitted: 1.4.2 Submission type: Standard Editor: !--editor-->@mpadge<!--end-editor-- Reviewers: @mikemahoney218, @paleolimbot
Due date for @mikemahoney218: 2024-08-07 Due date for @paleolimbot: 2024-08-07Archive: TBD Version accepted: TBD Language: en
Scope
Please indicate which category or categories from our package fit policies this package falls under:
Explain how and why the package falls under these categories (briefly, 1-2 sentences):
sits
is a package for satellite image time series analysis, that works with big Earth observation data sets.Who is the target audience and what are scientific applications of this package? The target audience is made of remote sensing and environmental experts that want to classify remote sensing images for applications such as deforestation detection, agricultural and land use/land cover mapping, biodiversity conservation, and land degradation monitoring.,
Are there other R packages that accomplish the same thing? If so, how does yours differ or meet our criteria for best-in-category? There are currently no other open source software packages that have the same capabilities.
(If applicable) Does your package comply with our guidance around Ethics, Data Privacy and Human Subjects Research? Not applicable
If you made a pre-submission inquiry, please paste the link to the corresponding issue, forum post, or other discussion, or @tag the editor you contacted. Not applicable
Explain reasons for any
pkgcheck
items which your package is unable to pass.(a) Vignettes: instead of preparing vignettes, the authors have written an on-line book that describes the contents of the package in detail. The book is available at the URL https://e-sensing.github.io/sitsbook/
Important notes:
(1) To run the tests, examples, and code coverage, please make sure the following environment variables are set in the R session: Sys.setenv("SITS_RUN_TESTS" = "YES") Sys.setenv("SITS_RUN_EXAMPLES" = "YES")
sits
is a fairly large package, and the tests take a long time to run, since they access cloud services. For this reason, testing needs to be manually enabled.(2) Please review version 1.4.2, not yet on CRAN, which is available in the "dev" branch in the github repository.
Technical checks
Confirm each of the following by checking the box.
This package:
Publication options
[x] Do you intend for this package to go on CRAN? The package is already on CRAN.
[ ] Do you intend for this package to go on Bioconductor?
[ x] Do you wish to submit an Applications Article about your package to Methods in Ecology and Evolution? If so:
MEE Options
- [x] The package is novel and will be of interest to the broad readership of the journal. - [x] The manuscript describing the package is no longer than 3000 words. - [x] You intend to archive the code for the package in a long-term repository which meets the requirements of the journal (see [MEE's Policy on Publishing Code](http://besjournals.onlinelibrary.wiley.com/hub/journal/10.1111/(ISSN)2041-210X/journal-resources/policy-on-publishing-code.html)) - (*Scope: Do consider MEE's [Aims and Scope](http://besjournals.onlinelibrary.wiley.com/hub/journal/10.1111/(ISSN)2041-210X/aims-and-scope/read-full-aims-and-scope.html) for your manuscript. We make no guarantee that your manuscript will be within MEE scope.*) - (*Although not required, we strongly recommend having a full manuscript prepared when you submit here.*) - (*Please do not submit your package separately to Methods in Ecology and Evolution*)Code of conduct