ropensci / software-review

rOpenSci Software Peer Review.
286 stars 104 forks source link

Energy database software query #611

Closed MatthewHeun closed 8 months ago

MatthewHeun commented 8 months ago

Submitting Author Name: Matthew Kuperus Heun Submitting Author Github Handle: !--author1-->@MatthewHeun<!--end-author1-- Repository: https://github.com/EnergyEconomyDecoupling/PFUAggDatabase Submission type: Pre-submission Language: en


Package: PFUAggDatabase
Title: Calculate Aggregations and Efficiencies For Energy Conversion Chains in PSUT Format
Version: 0.1.3
Date: 2022-08-19
Authors@R: 
    c(person(given = "Matthew",
             family = "Heun",
             role = c("aut", "cre"),
             email = "matthew.heun@me.com",
             comment = c(ORCID = "0000-0002-7438-214X")))
Description: It is helpful to be able to aggregate and calculate efficiencies for 
             energy conversion chains. 
             This package provides functions to support and create a `targets` workflow
             for such calculations.
             Several targets create outputs in different forms:
             `.csv` files, `.rds` files, and `.pdf` reports.
License: MIT + file LICENSE
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.2.3
Imports:
    dplyr,
    IEATools, 
    magrittr,
    matsbyname,
    matsindf,
    PFUDatabase,
    PFUPipelineTools,
    pins,
    RCLabels,
    readxl,
    Recca, 
    rlang,
    tarchetypes,
    targets,
    tidyr
Suggests: 
    devtools,
    ggplot2,
    knitr,
    MKHthemes,
    PFUSetup,
    rmarkdown,
    spelling,
    testthat (>= 3.0.0),
    tibble
Depends: 
    R (>= 2.10)
LazyData: true
Language: en-US
Config/testthat/edition: 3
VignetteBuilder: knitr

Scope

This PFUAggDatabase package builds a database (actually, a large data frame) of country-level primary, final, and useful energy and exergy aggregations from several data sources and own analyses for societal exergy analysis practitioners. The package supplies a {targets} pipeline and assists execution of that pipeline.

Not applicable.

These packages have the potential to be firmly integrated into multi-country and multi-sector energy analysis by practitioners at all levels worldwide. The data created by these packages are used by researchers in several countries for (a) historical energy and exergy analyses and (b) assessment of energy transition opportunities.

No other packages perform the same task.

Not applicable. Human subjects are not part of this research.

This package (PFUAggDatabase) is part of a suite of packages by myself and three other authors (@ZekeMarshall, @PaulBrockway, @earamendia). The packages work together to build the CL-PFU Database (Country-Level PFU Database). We submitted a paper covering the suite of packages to JOSS (https://github.com/EnergyEconomyDecoupling/CL-PFU-JOSS-Paper), but an editor shortage has pushed the paper to a waitlist (https://github.com/openjournals/joss-reviews/issues/5775).

With this pre-submission inquiry, we'd like to dialogue with rOpenSci about whether it makes sense to withdraw our paper from JOSS in favor of reviewing the suite of packages at rOpenSci (with a future submission to JOSS). The following tables provide the suite of packages that work together to create the CL-PFU Database:

On CRAN already:

Package Purpose
RCLabels Manipulates matrix row and column names in matsindf data frames
matsbyname Performs matrix mathematics that respects row and column names
matsindf Stores matrices in cells of data frames, thereby enabling analyses with tidyverse syntax

Available on GitHub:

Package Purpose
IEATools Converts IEA WEB data to RUVY matrices in matsindf data frames
MWTools Converts ILO and FAO data to RUVY matrices of human and animal muscle work in matsindf data frames
Recca Performs R energy conversion chain analysis
PFUSetup Identifies input and output locations for the PFUDatabase and PFUAggDatabase pipelines
PFUPipelineTools Provides basic functionality for all PFU pipelines
PFUDatabase Provides a [targets][link-targets] pipeline to create a data frame of RUVY matrices
PFUAggDatabase Provides a [targets][link-targets] pipeline to aggregate RUVY matrices

A few questions:

Thanks in advance for your feedback!

noamross commented 8 months ago

Thank you for you inquiry, @MatthewHeun! This is certainly an impressive suite of work.

MatthewHeun commented 8 months ago

Thanks for your reply! At this point, rOpenSci doesn't seem like a good fit for the suite of packages. We will consider other options for the suite. That said, {Recca} and {IEATools} are more general in nature and might be good to submit to rOpenSci at a later date. Thanks again for your quick response.