ropensci / software-review

rOpenSci Software Peer Review.
286 stars 104 forks source link

galamm: Generalized Additive Latent and Mixed Models #614

Closed osorensen closed 8 months ago

osorensen commented 8 months ago

Submitting Author Name: Øystein Sørensen Submitting Author Github Handle: !--author1-->@osorensen<!--end-author1-- Repository: https://github.com/LCBC-UiO/galamm Submission type: Pre-submission Language: en


Package: galamm
Title: Generalized Additive Latent and Mixed Models
Version: 0.1.1.9000
Authors@R: c(
    person(given = "Øystein",
           family = "Sørensen",
           role = c("aut", "cre"),
           email = "oystein.sorensen@psykologi.uio.no",
           comment = c(ORCID = "0000-0003-0724-3542")),
    person(given = "Douglas", family = "Bates", role = "ctb"),       
    person(given = "Ben", family = "Bolker", role = "ctb"),
    person(given = "Martin", family = "Maechler", role = "ctb"),
    person(given = "Allan", family = "Leal", role = "ctb"),
    person(given = "Fabian", family = "Scheipl", role = "ctb"),
    person(given = "Steven", family = "Walker", role = "ctb"),
    person(given = "Simon", family = "Wood", role = "ctb")
           )
Description: Estimates generalized additive latent and
    mixed models using maximum marginal likelihood, 
    as defined in Sorensen et al. (2023) 
    <doi:10.1007/s11336-023-09910-z>, which is an extension of Rabe-Hesketh and
    Skrondal (2004)'s unifying framework for multilevel latent variable 
    modeling <doi:10.1007/BF02295939>. Efficient computation is done using sparse 
    matrix methods, Laplace approximation, and automatic differentiation. The 
    framework includes generalized multilevel models with heteroscedastic 
    residuals, mixed response types, factor loadings, smoothing splines, 
    crossed random effects, and combinations thereof. Syntax for model 
    formulation is close to 'lme4' (Bates et al. (2015) 
    <doi:10.18637/jss.v067.i01>) and 'PLmixed' (Rockwood and Jeon (2019) 
    <doi:10.1080/00273171.2018.1516541>).
License: GPL (>= 3)
URL: https://github.com/LCBC-UiO/galamm, https://lcbc-uio.github.io/galamm/
BugReports: https://github.com/LCBC-UiO/galamm/issues
Encoding: UTF-8
Imports: 
    lme4,
    Matrix,
    memoise,
    methods,
    mgcv,
    nlme,
    Rcpp,
    Rdpack,
    stats
Depends:
    R (>= 3.5.0)
LinkingTo:
    Rcpp,
    RcppEigen
LazyData: true
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.2.3
Suggests:
    covr,
    gamm4,
    ggplot2,
    knitr,
    PLmixed,
    rmarkdown,
    testthat (>= 3.0.0)
Config/testthat/edition: 3
VignetteBuilder: knitr, rmarkdown
RdMacros: Rdpack
NeedsCompilation: yes
SystemRequirements: C++17

Scope

> as.data.frame(x) %>% group_by(type) %>% count()
# A tibble: 3 × 2
# Groups:   type [3]
  type           n
  <chr>      <int>
1 diagnostic    21
2 error          6
3 warning        5

For example, the first error has the following entry in the content column, and the other errors are similar.

> as.data.frame(x)[1, "content"]
[1] ":quote(y ~ x + (1 | id)), weights = base::quote(~(1 | : family_mapping must be a vector."

I don't know what this means, and I'm not able to figure it out by reading the documentation and vignettes of the autotest package. Anyhow, since the srr package is supposed to be used after autotest returns NULL, I haven't been able to try it.

noamross commented 8 months ago

Thank you @osorensen for this pre-submission inquiry! This package is well within our statistical scope and we'd be happy to review a full submission. While we recommend autotest, documentation of your standards compliance with srr and submission are not dependent on a clean autotest run.

@mpadge, can you provide some interpretation of this autotest result?

noamross commented 8 months ago

Thank you @osorensen for this pre-submission inquiry! This package is well within our statistical scope and we'd be happy to review a full submission. While we recommend autotest, documentation of your standards compliance with srr and submission are not dependent on a clean autotest run.

@mpadge, can you provide some interpretation of this autotest result?

mpadge commented 8 months ago

@noamross Those errors in autotest are a bug on our side. @osorensen Sorry for any inconvenience; feel free to ignore autotest results from here on (at least the errors), and continue with your submission.

osorensen commented 8 months ago

Thanks @noamross and @mpadge. I'll add srr tags and then submit in not too long.

@noamross, should I open a new issue for submission, or should I still use this pre-submission enquiry?

noamross commented 8 months ago

@osorensen Please open a new issue. Issues for full submissions will trigger our auto-checker.