ropensci / software-review

rOpenSci Software Peer Review.
286 stars 104 forks source link

tidyplate: transform microtiter plate data from xlsx and csv files into tidy dataframes #621

Closed shubhamdutta26 closed 5 months ago

shubhamdutta26 commented 6 months ago

Submitting Author Name: Shubham Dutta Submitting Author Github Handle: !--author1-->@shubhamdutta26<!--end-author1-- Other Package Authors Github handles: (comma separated, delete if none) @github_handle1, @github_handle2 Repository: https://github.com/shubhamdutta26/tidyplate Submission type: Pre-submission Language: en


Package: tidyplate
Type: Package
Title: Transform microplate data into a tidy dataframe
Version: 0.9.0
Authors@R: 
    person("Shubham", "Dutta", , "shubhamdutta26@gmail.com", role = c("aut", "cre"),
           comment = c(ORCID = "0000-0001-8484-0717"))
Description: The goal of tidyplate package is to help researchers convert different types of
    microplates into tidy dataframes which can be used in data analysis. It accepts xlsx and
    csv files formatted in a specific way as input. This package supports all types of 
    standard microplate formats such as 6-well, 12-well, 24-well, 48-well, 96-well, 384-well,
    and, 1536-well plates.
Imports: 
  janitor, 
  readr, 
  readxl,
  tibble,
  tidyr,
  dplyr,
  purrr,
  rlang
License: MIT + file LICENSE
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.2.3
URL: https://github.com/shubhamdutta26/tidyplate, http://www.shubhamdutta.com/tidyplate/
BugReports: https://github.com/shubhamdutta26/tidyplate/issues
Suggests: 
    knitr,
    rmarkdown,
    testthat (>= 3.0.0)
Config/testthat/edition: 3
VignetteBuilder: knitr

Scope

jhollist commented 6 months ago

@shubhamdutta26 Thank you for the pre-submission of tidyplate. Looks like a nice package that will help users like you that prefer to use excel for their microplate data.

I do have a primary concern in that there is quite a bit of overlap with the existing plater package. While adding excel as an acceptable format is a nice addition, I am not sure it satisfies the rOpenSci criteria for overlap (https://devguide.ropensci.org/policies.html#overlap). Could you provide some more details on the differences between your package and plater?

shubhamdutta26 commented 6 months ago

@shubhamdutta26 Thank you for the pre-submission of tidyplate. Looks like a nice package that will help users like you that prefer to use excel for their microplate data.

I do have a primary concern in that there is quite a bit of overlap with the existing plater package. While adding excel as an acceptable format is a nice addition, I am not sure it satisfies the rOpenSci criteria for overlap (https://devguide.ropensci.org/policies.html#overlap). Could you provide some more details on the differences between your package and plater?

Hello, Thank you for your reply. There is not much of a difference. I have used plater a lot of times and found it to be amazing (not sure why it did not include a function to import from excel sheets). Like I said the only difference is dealing with excel files which can nicely store experimental data and metadata in different sheets (for csv one needs multiple files).

jhollist commented 5 months ago

@shubhamdutta26 after some thought about tidyplate, I feel that it is not enough of a departure from existing packages to warrant a separate rOpenSci submission and review. One possibility you might think about is engaging the authors of the plater pacakge about a feature enhancement and pull request to plater that would add the ability to read in excel files. Best place to start with that would be via an issue (https://github.com/ropensci/plater/issues).

Thank you again for taking the time on the package and the pre-submission.