ropensci / software-review

rOpenSci Software Peer Review.
286 stars 104 forks source link

'nuts': Convert European Regional Data #623

Closed AAoritz closed 3 months ago

AAoritz commented 5 months ago

Date accepted: 2024-03-14 Submitting Author Name: Moritz Hennicke Submitting Author Github Handle: !--author1-->@AAoritz<!--end-author1-- Other Package Authors Github handles: !--author-others-->@krausewe<!--end-author-others-- Repository: https://github.com/AAoritz/nuts/ Version submitted: 0.0.0.9000 Submission type: Standard Editor: !--editor-->@maelle<!--end-editor-- Reviewers: @nolwenn, @jospueyo

Archive: TBD Version accepted: TBD Language: en


Package: nuts
Title: 'nuts': Convert European Regional Data
Version: 0.0.0.9000
Authors@R: c(person("Moritz", "Hennicke", email = "AAoritz@posteo.de", role = c("aut", "cre"),
           comment = c(ORCID = "0000-0001-6811-1821")),
         person("Werner", "Krause", email = "werner.krause@uni-potsdam.de", role = c("aut"),
           comment = c(ORCID = "0000-0002-5069-7964")))
Description: Motivated by changing administrative boundaries over time, the 'nuts' package can convert European regional data with NUTS codes between versions (2006, 2010, 2013, 2016 and 2021) and levels (NUTS 1, NUTS 2 and NUTS 3). The package uses spatial interpolation based on granular (100mx100m) population and land use data provided by the European Commission's Joint Research Center.  
URL: https://AAoritz.github.io/nuts/
BugReports: https://github.com/AAoritz/nuts/
License: MIT + file LICENSE
Encoding: UTF-8
Roxygen: list(markdown = TRUE)
RoxygenNote: 7.3.1
Suggests: 
    distill,
    eurostat,
    formatR,
    ggalluvial,
    ggfittext,
    ggplot2,
    ggpubr,
    ggrepel,
    gridExtra,
    kableExtra,
    knitr,
    raster,
    RColorBrewer,
    readr,
    rmarkdown,
    sf,
    terra,
    testthat,
    tidyr
Config/testthat/edition: 3
VignetteBuilder: knitr
Imports:
    crayon,
    dplyr,
    stringr
Depends: 
    R (>= 3.5.0)
LazyData: true

Scope

Data munging: Linking regional data from different sources at the level of NUTS codes is often complicated by the usage of different versions or varying levels of geographical granularity across sources. The package can be used to harmonize NUTS versions and levels across different data sources using spatial interpolation.

Data validation and testing: The package includes routine tasks to test for the validity and completeness of NUTS codes.

Geospatial data: NUTS codes are the dominant format for European regional data.

The target audience are academics, journalists and data scientists interested in European regional data. Users who want to exploit changes within NUTS regions over time face the challenge that administrative boundaries are redrawn over time. The package enables the construction of consistent panel data across NUTS regions and over time through the harmonization of NUTS regions to one common version or level of granularity.

To our knowledge there is currently no package that is targeted at the conversion of NUTS versions using spatial interpolation.

The regions package allows for re-coding of NUTS codes from version to version without spatial interpolation. The package offers some code validation routines, but not an automated detection of the NUTS version used.

Yes

Technical checks

Confirm each of the following by checking the box.

This package:

Publication options

Code of conduct

maelle commented 3 months ago

@nolwenn could you please read the response of the authors and respond?

nolwenn commented 3 months ago

Reviewer Response

I enjoyed reviewing your package and was happy you found my comments valuable. Sorry for the late replies to your answers.

About the remaining points of discussion:

  1. I have no longer the namespace error message. All seems working out well.

  2. r nuts_convert_version()

    • including an option in r nuts_convert_version() that could return e.g. a column in the converted dataset containing more details on the conversion could indeed be an interesting way of doing implementing it.
    • an example in the vignette on how to extracted, by sub-setting and transforming the tibble data(cross_walks) is also nice
  3. Missing regions : weights missing due to missing regions by changing the r missing_rm option to a threshold at which the users feel confident to assume 0 for the missing regions is a good idea to implement.

Final approval (post-review)

Estimated hours spent reviewing: 1 hour

AAoritz commented 3 months ago

Many thanks @nolwenn and @jospueyo for both of your enthusiastic and speedy reviews and your final approval. Based on your last comments we made the following edits:

Your comments made a big difference for this package! Thank you for your time and efforts!

AAoritz commented 3 months ago

One question on verbosity control @maelle. We thought that our current implementation using rlang::local_options() based on your recommendations would set verbosity as a default. However, verbosity has to be switched on to function. Do you understand why?

maelle commented 3 months ago

In https://github.com/AAoritz/nuts/blob/cf42cce8e522d4bd9ae1e8506024620dd964cebe/R/nuts_convert_version.R#L299

is_verbose_mode <- (getOption("nuts.verbose", "quiet") == "verbose")

The default is "quiet", not "verbose".

Change the line to:

is_verbose_mode <- (getOption("nuts.verbose", "verbose") == "verbose")
maelle commented 3 months ago

Thanks @jospueyo & @nolwenn for your work as reviewers!

Thanks @AAoritz @krausewe for your work on your package!

maelle commented 3 months ago

@ropensci-review-bot approve nuts

ropensci-review-bot commented 3 months ago

Approved! Thanks @AAoritz for submitting and @nolwenn, @jospueyo for your reviews! :grin:

To-dos:

Should you want to acknowledge your reviewers in your package DESCRIPTION, you can do so by making them "rev"-type contributors in the Authors@R field (with their consent).

Welcome aboard! We'd love to host a post about your package - either a short introduction to it with an example for a technical audience or a longer post with some narrative about its development or something you learned, and an example of its use for a broader readership. If you are interested, consult the blog guide, and tag @ropensci/blog-editors in your reply. They will get in touch about timing and can answer any questions.

We maintain an online book with our best practice and tips, this chapter starts the 3d section that's about guidance for after onboarding (with advice on releases, package marketing, GitHub grooming); the guide also feature CRAN gotchas. Please tell us what could be improved.

Last but not least, you can volunteer as a reviewer via filling a short form.

AAoritz commented 3 months ago

Makes sense... we set the default to verbose. Thank you @maelle for this, your super helpful comments and your work as the editor during the review process! @krausewe and I learned a lot!

AAoritz commented 3 months ago

@nolwenn and @jospueyo, many thanks again! Please let us know if we can add you in the meta description as reviewers of the package. @maelle can we include you as well?!

ropensci-review-bot commented 3 months ago

I'm sorry human, I don't understand that. You can see what commands I support by typing:

@ropensci-review-bot help

AAoritz commented 3 months ago

@ropensci-review-bot finalize transfer of nuts

ropensci-review-bot commented 3 months ago

Transfer completed. The nuts team is now owner of the repository and the author has been invited to the team

maelle commented 3 months ago

@maelle can we include you as well?!

Thanks for asking, but there's no need to list editors. Your participation in this process is thanks enough :smile_cat:

nolwenn commented 3 months ago

@nolwenn and @jospueyo, many thanks again! Please let us know if we can add you in the meta description as reviewers of the package. @maelle can we include you as well?!

Thanks for proposing. I do not know the convention but do as you like. As @maelle I am already happy to know that I helped.

jospueyo commented 3 months ago

@nolwenn and @jospueyo, many thanks again! Please let us know if we can add you in the meta description as reviewers of the package. @maelle can we include you as well?!

Thanks for proposing. I do not know the convention but do as you like. As @maelle I am already happy to know that I helped.

I'd be honoured to be recognized for my tiny contribution to your so useful package.

AAoritz commented 3 months ago

Should you want to acknowledge your reviewers in your package DESCRIPTION, you can do so by making them "rev"-type contributors in the Authors@R field (with their consent).

Including referees into the DESCRIPTION field is encouraged as you can see and we believe that it's a great idea in this context! Thanks a lot everybody!