Closed AAoritz closed 3 months ago
@nolwenn could you please read the response of the authors and respond?
I enjoyed reviewing your package and was happy you found my comments valuable. Sorry for the late replies to your answers.
About the remaining points of discussion:
I have no longer the namespace error message. All seems working out well.
r nuts_convert_version()
r nuts_convert_version()
that could return e.g. a column in the converted dataset containing more details on the conversion could indeed be an interesting way of doing implementing it.Missing regions : weights missing due to missing regions by changing the r missing_rm
option to a threshold at which the users feel confident to assume 0 for the missing regions is a good idea to implement.
Estimated hours spent reviewing: 1 hour
Many thanks @nolwenn and @jospueyo for both of your enthusiastic and speedy reviews and your final approval. Based on your last comments we made the following edits:
Your comments made a big difference for this package! Thank you for your time and efforts!
One question on verbosity control @maelle. We thought that our current implementation using rlang::local_options()
based on your recommendations would set verbosity as a default. However, verbosity has to be switched on to function. Do you understand why?
is_verbose_mode <- (getOption("nuts.verbose", "quiet") == "verbose")
The default is "quiet", not "verbose".
Change the line to:
is_verbose_mode <- (getOption("nuts.verbose", "verbose") == "verbose")
Thanks @jospueyo & @nolwenn for your work as reviewers!
Thanks @AAoritz @krausewe for your work on your package!
@ropensci-review-bot approve nuts
Approved! Thanks @AAoritz for submitting and @nolwenn, @jospueyo for your reviews! :grin:
To-dos:
@ropensci-review-bot invite me to ropensci/<package-name>
which will re-send an invitation.@ropensci-review-bot finalize transfer of <package-name>
where <package-name>
is the repo/package name. This will give you admin access back.pkgdown
website and are ok relying only on rOpenSci central docs building and branding,
pkgdown
website with a redirecting pagehttps://docs.ropensci.org/package_name
URL
field alongside the link to the GitHub repository, e.g.: URL: https://docs.ropensci.org/foobar, https://github.com/ropensci/foobar
codemetar::write_codemeta()
in the root of your package.install.packages("<package-name>", repos = "https://ropensci.r-universe.dev")
thanks to R-universe.Should you want to acknowledge your reviewers in your package DESCRIPTION, you can do so by making them "rev"
-type contributors in the Authors@R
field (with their consent).
Welcome aboard! We'd love to host a post about your package - either a short introduction to it with an example for a technical audience or a longer post with some narrative about its development or something you learned, and an example of its use for a broader readership. If you are interested, consult the blog guide, and tag @ropensci/blog-editors in your reply. They will get in touch about timing and can answer any questions.
We maintain an online book with our best practice and tips, this chapter starts the 3d section that's about guidance for after onboarding (with advice on releases, package marketing, GitHub grooming); the guide also feature CRAN gotchas. Please tell us what could be improved.
Last but not least, you can volunteer as a reviewer via filling a short form.
Makes sense... we set the default to verbose
. Thank you @maelle for this, your super helpful comments and your work as the editor during the review process! @krausewe and I learned a lot!
@nolwenn and @jospueyo, many thanks again! Please let us know if we can add you in the meta description as reviewers of the package. @maelle can we include you as well?!
I'm sorry human, I don't understand that. You can see what commands I support by typing:
@ropensci-review-bot help
@ropensci-review-bot finalize transfer of nuts
Transfer completed.
The nuts
team is now owner of the repository and the author has been invited to the team
@maelle can we include you as well?!
Thanks for asking, but there's no need to list editors. Your participation in this process is thanks enough :smile_cat:
@nolwenn and @jospueyo, many thanks again! Please let us know if we can add you in the meta description as reviewers of the package. @maelle can we include you as well?!
Thanks for proposing. I do not know the convention but do as you like. As @maelle I am already happy to know that I helped.
@nolwenn and @jospueyo, many thanks again! Please let us know if we can add you in the meta description as reviewers of the package. @maelle can we include you as well?!
Thanks for proposing. I do not know the convention but do as you like. As @maelle I am already happy to know that I helped.
I'd be honoured to be recognized for my tiny contribution to your so useful package.
Should you want to acknowledge your reviewers in your package DESCRIPTION, you can do so by making them "rev"-type contributors in the Authors@R field (with their consent).
Including referees into the DESCRIPTION field is encouraged as you can see and we believe that it's a great idea in this context! Thanks a lot everybody!
Date accepted: 2024-03-14 Submitting Author Name: Moritz Hennicke Submitting Author Github Handle: !--author1-->@AAoritz<!--end-author1-- Other Package Authors Github handles: !--author-others-->@krausewe<!--end-author-others-- Repository: https://github.com/AAoritz/nuts/ Version submitted: 0.0.0.9000 Submission type: Standard Editor: !--editor-->@maelle<!--end-editor-- Reviewers: @nolwenn, @jospueyo
Archive: TBD Version accepted: TBD Language: en
Scope
Please indicate which category or categories from our package fit policies this package falls under: (Please check an appropriate box below. If you are unsure, we suggest you make a pre-submission inquiry.):
Explain how and why the package falls under these categories (briefly, 1-2 sentences):
Data munging: Linking regional data from different sources at the level of NUTS codes is often complicated by the usage of different versions or varying levels of geographical granularity across sources. The package can be used to harmonize NUTS versions and levels across different data sources using spatial interpolation.
Data validation and testing: The package includes routine tasks to test for the validity and completeness of NUTS codes.
Geospatial data: NUTS codes are the dominant format for European regional data.
The target audience are academics, journalists and data scientists interested in European regional data. Users who want to exploit changes within NUTS regions over time face the challenge that administrative boundaries are redrawn over time. The package enables the construction of consistent panel data across NUTS regions and over time through the harmonization of NUTS regions to one common version or level of granularity.
To our knowledge there is currently no package that is targeted at the conversion of NUTS versions using spatial interpolation.
The
regions
package allows for re-coding of NUTS codes from version to version without spatial interpolation. The package offers some code validation routines, but not an automated detection of the NUTS version used.Yes
If you made a pre-submission inquiry, please paste the link to the corresponding issue, forum post, or other discussion, or @tag the editor you contacted.
Explain reasons for any
pkgcheck
items which your package is unable to pass.Technical checks
Confirm each of the following by checking the box.
This package:
Publication options
Code of conduct