Closed b-rodrigues closed 4 months ago
We’ve added some more tests:
more than this will be tricky though.
@b-rodrigues Just wanted to confirm that this is on our radar. {rix} looks really interesting.
The editorial board is having some discussions about the rix package and we will get back to you shortly!
Hi, thanks for letting us know! There's no rush we are still ironing out some bugs 🪲🪲
@b-rodrigues We have had a chance to discuss your pre-submission inquiry. The gist of our discussion was that, {rix} looks really interesting and has an obvious use case for reproducibility, and {rix} best fit is in the workflow automation category.
We would like to invite you to make a full submission. A few things to keep in mind in that full submission.
First, as long as tests are adequate and they run locally, not running on CI is fine, just make sure to document how to demonstrate local coverage in the packages CONTRIBUTING. Second, it might be possible to add Nix to the RO build system but we would need to look a little more closely at it. @mpadge will be doing that and will follow up with you.
One quick logistical note, my stint as Editor in Chief has come to an end. @ldecicco-USGS just started her rotation and she will take over for me!
Thank you again for this pre-submission!
Submitting Author Name: Bruno Rodrigues Submitting Author Github Handle: !--author1-->@b-rodrigues<!--end-author1-- Other Package Authors Github handles: !--author-others-->@philipp-baumann<!--end-author-others-- Repository: https://github.com/b-rodrigues/rix Submission type: Pre-submission Language: en
Scope
Please indicate which category or categories from our package fit policies or statistical package categories this package falls under. (Please check an appropriate box below):
Data Lifecycle Packages
[ ] data retrieval
[ ] data extraction
[ ] data munging
[ ] data deposition
[ ] data validation and testing
[ ] workflow automation
[ ] version control
[ ] citation management and bibliometrics
[ ] scientific software wrappers
[x] field and lab reproducibility tools
[ ] database software bindings
[ ] geospatial data
[ ] text analysis
Statistical Packages
[ ] Bayesian and Monte Carlo Routines
[ ] Dimensionality Reduction, Clustering, and Unsupervised Learning
[ ] Machine Learning
[ ] Regression and Supervised Learning
[ ] Exploratory Data Analysis (EDA) and Summary Statistics
[ ] Spatial Analyses
[ ] Time Series Analyses
Explain how and why the package falls under these categories (briefly, 1-2 sentences). Please note any areas you are unsure of:
The package's aim is to help users define reproducible development environment which can then be built using the Nix package manager. These environments will contain all the required software.
Anyone that needs reproducibility.
There is no other package, as far as we know, that accomplishes the same thing. This package generates Nix expressions and by itself will not generate the reproducible development environment. This environment will need to be built using Nix. To achieve the same thing, Docker+renv (for example) should be used.
Not applicable.
We will likely not be able to reach the 75% of unit test coverage. This is mainly for two reasons:
We were wondering if we could have an exemption of this requirement? We could likely install Nix on GA runners so that the tests that require Nix could pass, but I don't know if we could solve the issue with covr::package_coverage(). We use
skip_covr()
for now.Here's the output of test coverage on GA:
Here's the coverage:
and here's the pkgcheck action complaining:
If Nix is available, all tests pass locally with
devtools::test()
, but computing the coverage fails because of that one test that for some reason fails withcovr::package_cover()
(which now has a skip, as explained), if Nix is not available, the test that requires Nix gets also skipped.