Closed abigailkeller closed 7 months ago
@ropensci-review-bot check srr
This is not an 'srr' package
Hi @abigailkeller I'm new to the editor process for the stats submissions, so sorry for the delay.
The stat submission guide is here: https://stats-devguide.ropensci.org/pkgdev.html
I think the next step for you is to follow the directions here: https://stats-devguide.ropensci.org/pkgdev.html#pkgdev-srr https://github.com/ropensci-review-tools/srr
The eDNAjoint would need srr results to >50% before we can move the package to a full submission.
Closing issue as my package seems out of scope for statistical submissions
Hi @abigailkeller, Mark here from the rOpenSci stats team, to politely disagree with you about your package being out of scope. Scope decisions for stats packages are pretty straightforward: If you think that your package can comply with at least half of all applicable standards - in your case General and Bayesian, then it is by definition in scope.
Please feel free to have a look through your code, documentation, and tests, check all standards you think will likely apply, and if that seems like more than half, you are very welcome to open this issue again. Then, once you've documented compliance, ask the bot to call check srr
yourself. As long as that requirement is met, the submission may then proceed. Thanks :smile:
Re-opened issue. I believe my package is now passing at least 55% of the general statistics and Bayesian statistics standards. Thanks!
@ropensci-review-bot check srr
@abigailkeller Sorry, check results got lost due to upgrades in our system. They'll appear sometime tomorrow. Sorry for any inconvenience.
The following standards are missing:
General standards:
G1.5, G5.4, G5.5
Bayesian standards:
BS1.2b, BS1.2c, BS1.4, BS4.0, BS4.3, BS6.2, BS6.3
All standards must be documented prior to submission
Just to add to the ropensci-review-bot: I believe the missing standards (G1.5, G5.4, G5.5,BS1.2b, BS1.2c, BS1.4, BS4.0, BS4.3, BS6.2, BS6.3) are in the .Rmd file in the vignette folder
The following standards are missing:
General standards:
G5.4, G5.5
All standards must be documented prior to submission
There are also 39 standards with 'srrstatsTODO' tags.
@ldecicco-USGS That srr
check by the bot should now be correct. @abigailkeller You can call srr::srr_stats_pre_submit()
locally to confirm that your package will pass, and then ask the bot here to check srr
when you think you've finished documenting. Sorry both for any inconvenience here.
@ropensci-review-bot check srr
:heavy_check_mark: This package complies with > 50% of all standads and may be submitted.
@ldecicco-USGS Is there anything I need to do to move this from a submission inquiry to a submission? Thanks!
Thank you @abigailkeller for this pre-submission inquiry! This package is well within our statistical scope and we'd be happy to review a full submission. So now you'll need to open a new issue for the full submission. Let me know if you have any questions.
(see issue 615 for a recent example of a submission, where the pre-submission is 614)
Submitting Author Name: Abigail Keller Submitting Author Github Handle: !--author1-->@abigailkeller<!--end-author1-- Repository: https://github.com/abigailkeller/eDNAjoint Submission type: Pre-submission Language: en
Scope
Please indicate which category or categories from our package fit policies or statistical package categories this package falls under. (Please check an appropriate box below):
Data Lifecycle Packages
[ ] data retrieval
[ ] data extraction
[ ] data munging
[ ] data deposition
[ ] data validation and testing
[ ] workflow automation
[ ] version control
[ ] citation management and bibliometrics
[ ] scientific software wrappers
[ ] field and lab reproducibility tools
[ ] database software bindings
[ ] geospatial data
[ ] text analysis
Statistical Packages
[x] Bayesian and Monte Carlo Routines
[ ] Dimensionality Reduction, Clustering, and Unsupervised Learning
[ ] Machine Learning
[ ] Regression and Supervised Learning
[ ] Exploratory Data Analysis (EDA) and Summary Statistics
[ ] Spatial Analyses
[ ] Time Series Analyses
Explain how and why the package falls under these categories (briefly, 1-2 sentences). Please note any areas you are unsure of:
This package runs Bayesian statistical models written in Stan using data from paired environmental DNA (eDNA) and traditional surveys provided by a user. Additional functions support interpretation of model output.
Not yet.
The target audience is environmental science researchers or managers who want to interpret environmental DNA data but do not have experience writing and implementing custom Bayesian models.
To my knowledge, no other R package implements similar types of models. Although the R package contains additional model variations, the model was originally developed in a publication: "Tracking an invasion front with environmental DNA", led by the authors of this submission.
Yes