ropensci / software-review

rOpenSci Software Peer Review.
286 stars 104 forks source link

phangorn #641

Closed KlausVigo closed 3 weeks ago

KlausVigo commented 2 months ago

Submitting Author Name: Klaus Schliep Submitting Author Github Handle: !--author1-->@KlausVigo<!--end-author1-- Other Package Authors Github handles: (comma separated, delete if none) @emmanuelparadis, @liamrevell,@darunabas,@leomrtns Repository: https://github.com/KlausVigo/phangorn Submission type: Pre-submission Language: en


Package: phangorn
Title: Phylogenetic Reconstruction and Analysis
Version: 3.0.0
Authors@R: 
    c(person("Klaus", "Schliep", role = c("aut", "cre"),
             email = "klaus.schliep@gmail.com",
             comment = c(ORCID = "0000-0003-2941-0161")),
      person("Emmanuel", "Paradis", role = "aut",
             comment = c(ORCID = "0000-0003-3092-2199")),
      person("Leonardo", "de Oliveira Martins", role = "aut",
             comment = c(ORCID = "0000-0001-5247-1320")),
      person("Alastair", "Potts", role = "aut"),
      person("Iris", "Bardel-Kahr", role = "aut",
             comment = c(ORCID = "0000-0002-8950-834X")),            
      person("Tim W.", "White", role = "ctb"),
      person("Cyrill", "Stachniss", role = "ctb"),
      person("Michelle", "Kendall", role = "ctb",
             email = "m.kendall@imperial.ac.uk"),
      person("Keren", "Halabi",  role = "ctb"),
      person("Richel", "Bilderbeek",  role = "ctb"),
      person("Kristin", "Winchell", role = "ctb"),
      person("Liam", "Revell", role = "ctb"),
      person("Mike", "Gilchrist", role = "ctb"),
      person("Jeremy", "Beaulieu", role = "ctb"),
      person("Brian", "O'Meara", role = "ctb"),
      person("Long", "Qu", role = "ctb"), 
      person(given= "Joseph", "Brown", role = "ctb", 
             comment = c(ORCID = "0000-0002-3835-8062")),
      person(given="Santiago", "Claramunt", role = "ctb", 
             comment = c(ORCID = "0000-0002-8926-5974")))
Description: Allows for estimation of phylogenetic trees and networks
    using Maximum Likelihood, Maximum Parsimony, distance methods and
    Hadamard conjugation (Schliep 2011). Offers methods for tree comparison, 
    model selection and visualization of phylogenetic networks as described in
    Schliep et al. (2017).
License: GPL (>= 2)
URL: https://github.com/KlausVigo/phangorn,
    https://klausvigo.github.io/phangorn/
BugReports: https://github.com/KlausVigo/phangorn/issues
Depends:
    ape (>= 5.8),
    R (>= 4.1.0)
Imports:
    digest,
    fastmatch,
    generics,
    ggseqlogo,
    ggplot2,
    graphics,
    grDevices,
    igraph (>= 1.0),
    Matrix,
    methods,
    parallel,
    quadprog,
    Rcpp,
    stats,
    utils
Suggests:
    apex,
    Biostrings,
    knitr,
    magick,
    rgl,
    rmarkdown,
    seqinr,
    tinytest,
    vdiffr,
    xtable
LinkingTo:
    Rcpp
Remotes: github::EmmanuelParadis/ape
VignetteBuilder: 
    knitr,
    utils
biocViews: Software, Technology, QualityControl
Encoding: UTF-8
Repository: CRAN
Roxygen: list(old_usage = TRUE)
RoxygenNote: 7.3.1
Language: en-US

Scope

N/A

We are writing a new software note of the package phangorn as we plan to submit . We especially appreciate feedback which improving the package as well as making the package easier to maintain and thus avoiding to get "Ripleyed" in the future. We tried in the recent time to make several workflows easier to follow (adding the function `pml_bb) and improved the vignettes, any ideas in this respect are very welcome.

The package differs from most other submissions as it is already for over 15 years on CRAN and is considerably larger than the usual submission to rOpenSci. We are fully aware that the naming of functions is not consistent (the underscore was an assignment operator when the main author started using R) and the package has around 50 reverse dependencies on CRAN and 150 on rOpenSci so changing function names is not a trivial task.

We are currently working to check the last few ticks with pkgcheck.

Kind regards, Klaus Schliep

jooolia commented 1 month ago

Dear @KlausVigo, Many thanks for your submission of this long-standing package. It seems possible that the statistical category "Dimensionality Reduction, Clustering, and Unsupervised Learning" could be a good fit. Would it be possible to comply with the Dimensionality Reduction standards and potentially the Probability Distributions standards?

Many thanks, Julia

jooolia commented 3 weeks ago

Dear @KlausVigo, Thanks for your pre-submission. With no response from your end I will close this issue, but feel free to re-open with follow up questions. Thanks, Julia