ropensci / software-review

rOpenSci Software Peer Review.
291 stars 104 forks source link

pre-submission inquiry: fireexposuR #652

Closed heyairf closed 1 month ago

heyairf commented 1 month ago

Submitting Author Name: Air Forbes Submitting Author Github Handle: !--author1-->@heyairf<!--end-author1--

Repository: https://github.com/heyairf/fireexposuR Submission type: Pre-submission Language: en


Type: Package
Package: fireexposuR
Title: Compute and Visualize Wildfire Exposure
Version: 0.2.0
Authors@R: c(person("Air", "Forbes", email = "amforbes@ualberta.ca", 
    role = c("aut", "cre"), comment = c(ORCID = "0000-0002-9842-7648")),
    person("Jennifer", "Beverly", role = "aut"))
Description: This package computes wildfire exposure using methods from
    Beverly et al. (2010), Beverly et al. (2021), and Beverly and Forbes
    (2023).  It provides functions to standardize the mapping and
    visualization of wildfire exposure. This package requires
    pre-processing of data which is documented in Forbes and Beverly
    (Manuscript in preparation).
License: GPL (>= 3)
Imports: 
    dplyr,
    geosphere,
    ggplot2,
    ggspatial,
    magrittr,
    maptiles,
    MultiscaleDTM,
    rlang,
    terra,
    tidyr,
    tidyselect,
    tidyterra
Encoding: UTF-8
LazyData: true
RoxygenNote: 7.3.1
Roxygen: list(markdown = TRUE)
URL: https://github.com/heyairf/fireexposuR
BugReports: https://github.com/heyairf/fireexposuR/issues
Suggests: 
    testthat (>= 3.0.0)
Config/testthat/edition: 3
Depends: 
    R (>= 2.10)

Scope

This package was developed to share methodologies from existing research by modifying/expanding existing functions. The functions automate and standardize assessments to increase access and quality assurance in the calculation for interested users.

n/a

Users interested in wildfire risk assessments including but not limited to researchers, consultants, planners, land use decision makers.

There are no other R packages that fill this role.

n/a

My pre-submission inquiry is surrounding the test suite. I am very new to R package development and am unsure how to use testthat appropriately in my project. Examples online are very simple, and because of the spatial analysis most functions are using S4 objects which seems to complicate things further. I have attempted to find answers through my university and haven't been able to find any support. Would anyone be able to advise me on this or steer me to someone who could? I believe it is the only element that needs addressing before I can submit my package.

adamhsparks commented 1 month ago

Hi @heyairf, this isn't really the proper place to offer support for this request. We're happy to help but I'd suggest you try the rOpenSci forums, https://discuss.ropensci.org or if you prefer a Slack interface you could try https://dslc.io, the "Data Science Learning Community". Either place should be able to give you some guidance and answer your questions.

Since this is a pre-submission inquiry, from the looks of it the package would be in-scope if it had testing infrastructure that it currently lacks.

adamhsparks commented 1 month ago

If you haven't, you should refer to the Testing packages chapter in the "R-pkgs" book, https://r-pkgs.org/testing-basics.html.

A further suggestion from the editors was to check other spatial packages for their test-suites and see how they implemented them. https://github.com/r-spatialecology/landscapemetrics/tree/main/tests/testthat is one that was suggested.

I'll close this issue now. Please feel free to open a new issue for software review when you've addressed this issue with the package.

heyairf commented 1 month ago

My apologies, thanks for directing me to the right place to ask!

adamhsparks commented 1 month ago

No worries. It looks like a nice package. 😊

adamhsparks commented 1 month ago

Hi @heyairf, @maurolepore had some further suggestions that I was remiss in reporting back here. So here they are.

And I also really like the testing chapters in a less-obvious book: Mastering shiny. If you skip the content that is specific to shiny, you're left with an incredibly concise and complete introduction to testing: 21.1 Testing functions (except 21.1.4) 21.2 Workflow 21.6 Philosophy

and Mauro also has a YouTube playlist on testing in R, https://www.youtube.com/playlist?list=PLvgdJdJDL-APxwVpLE7vjeg-Pgdd4e64W&themeRefresh=1

heyairf commented 4 weeks ago

Thank you for the additional resources! I really appreciate it. I have just posted my most pressing/specific question in the discussion forum here.