Closed heyairf closed 1 month ago
Hi @heyairf, this isn't really the proper place to offer support for this request. We're happy to help but I'd suggest you try the rOpenSci forums, https://discuss.ropensci.org or if you prefer a Slack interface you could try https://dslc.io, the "Data Science Learning Community". Either place should be able to give you some guidance and answer your questions.
Since this is a pre-submission inquiry, from the looks of it the package would be in-scope if it had testing infrastructure that it currently lacks.
If you haven't, you should refer to the Testing packages chapter in the "R-pkgs" book, https://r-pkgs.org/testing-basics.html.
A further suggestion from the editors was to check other spatial packages for their test-suites and see how they implemented them. https://github.com/r-spatialecology/landscapemetrics/tree/main/tests/testthat is one that was suggested.
I'll close this issue now. Please feel free to open a new issue for software review when you've addressed this issue with the package.
My apologies, thanks for directing me to the right place to ask!
No worries. It looks like a nice package. 😊
Hi @heyairf, @maurolepore had some further suggestions that I was remiss in reporting back here. So here they are.
And I also really like the testing chapters in a less-obvious book: Mastering shiny. If you skip the content that is specific to shiny, you're left with an incredibly concise and complete introduction to testing: 21.1 Testing functions (except 21.1.4) 21.2 Workflow 21.6 Philosophy
and Mauro also has a YouTube playlist on testing in R, https://www.youtube.com/playlist?list=PLvgdJdJDL-APxwVpLE7vjeg-Pgdd4e64W&themeRefresh=1
Submitting Author Name: Air Forbes Submitting Author Github Handle: !--author1-->@heyairf<!--end-author1--
Repository: https://github.com/heyairf/fireexposuR Submission type: Pre-submission Language: en
Scope
Please indicate which category or categories from our package fit policies or statistical package categories this package falls under. (Please check one or more appropriate boxes below):
Data Lifecycle Packages
[ ] data retrieval
[ ] data extraction
[ ] data munging
[ ] data deposition
[x] data validation and testing
[x] workflow automation
[ ] version control
[ ] citation management and bibliometrics
[ ] scientific software wrappers
[ ] field and lab reproducibility tools
[ ] database software bindings
[x] geospatial data
[ ] text analysis
Statistical Packages
[ ] Bayesian and Monte Carlo Routines
[ ] Dimensionality Reduction, Clustering, and Unsupervised Learning
[ ] Machine Learning
[ ] Regression and Supervised Learning
[ ] Exploratory Data Analysis (EDA) and Summary Statistics
[ ] Spatial Analyses
[ ] Time Series Analyses
[ ] Probability Distributions
Explain how and why the package falls under these categories (briefly, 1-2 sentences). Please note any areas you are unsure of:
This package was developed to share methodologies from existing research by modifying/expanding existing functions. The functions automate and standardize assessments to increase access and quality assurance in the calculation for interested users.
n/a
Users interested in wildfire risk assessments including but not limited to researchers, consultants, planners, land use decision makers.
There are no other R packages that fill this role.
n/a
My pre-submission inquiry is surrounding the test suite. I am very new to R package development and am unsure how to use testthat appropriately in my project. Examples online are very simple, and because of the spatial analysis most functions are using S4 objects which seems to complicate things further. I have attempted to find answers through my university and haven't been able to find any support. Would anyone be able to advise me on this or steer me to someone who could? I believe it is the only element that needs addressing before I can submit my package.