ropensci / software-review

rOpenSci Software Peer Review.
292 stars 104 forks source link

fuse package #69

Closed cvitolo closed 8 years ago

cvitolo commented 8 years ago

Summary

Package: fuse
Version: 3.0.0
Title: Framework for Understanding Structural Errors
Authors@R: c(person("Claudia", "Vitolo", role = c("aut", "cre"),
                    email = "cvitolodev@gmail.com"),
               person("Peter", "Wells", role = "ctr"),
               person("Martin", "Dobias", role = "ctr"),
               person("Wouter", "Buytaert", role = "ths"))
Author: Claudia Vitolo [aut, cre], Peter Wells [ctr], Martin Dobias [ctr],
    Wouter Buytaert [ths]
Maintainer: Claudia Vitolo <cvitolodev@gmail.com>
Depends:
    R (>= 3.1.0),
    zoo,
    tgp
LinkingTo: BH, Rcpp
Description: Implementation of the framework for hydrological modelling FUSE,
    based on the Fortran version described in Clark et al. (2008). The package
    consists of two modules: Soil Moisture Accounting module (\code{fuse.sim}) and
    Gamma routing module (\code{routgamma.sim}). It also contains default parameter
    ranges (see \code{fuse.ranges} and \code{routgamma.ranges}) and three data
    objects: DATA, parameters and modlist.
License: GPL (>= 3)
Repository: GitHub
URL: https://github.com/cvitolo/r_fuse
BugReports: https://github.com/cvitolo/r_fuse/issues
RoxygenNote: 5.0.1

Confirm each of the following by checking the box. This package:

R CMD check succeeds with no ERRORs or WARNINGs. However there is 1 NOTE:

Compiled code should not call entry points which might terminate R nor write to stdout/stderr instead of to the console, nor the system RNG.

I do not know how to modify the c++ code to fix this.

sckott commented 8 years ago

Editor checks:


@cvitolo Thanks for your submission! This is a nice package, but we think it falls outside the scope of rOpenSci. We encourage submitting to CRAN and to JOSS.

sckott commented 8 years ago

@cvitolo let me know if you have any questions / want to discuss this decision