search

ropensci / spelling

Tools for Spell Checking in R
https://docs.ropensci.org/spelling
Other
107 stars 25 forks source link

Ensure that `spell_check_setup()` doesn't induce a `goodpractice::gp()` error #16

Closed rorynolan closed 5 years ago

rorynolan commented 5 years ago

As it stands, the spelling.R file created by spell_check_setup() has a line beyond 80 characters, which goodpractice::gp() complains about. This is a small point but I guess that it would be good to rectify this. Just to clarify, I'm not suggesting that the whole spelling package should itself conform to this 80 char limit, I'm just saying that perhaps the files that it writes to other packages should. Thanks, Rory

codecov-io commented 5 years ago

Codecov Report

Merging #16 into master will decrease coverage by 0.18%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master      #16      +/-   ##
==========================================
- Coverage   45.56%   45.38%   -0.19%     
==========================================
  Files           6        6              
  Lines         248      249       +1     
==========================================
  Hits          113      113              
- Misses        135      136       +1
Impacted Files Coverage Δ
R/spell-check.R 35.04% <0%> (-0.31%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 1a3c45c...a1a5ce2. Read the comment docs.