ropensci / spelling

Tools for Spell Checking in R
https://docs.ropensci.org/spelling
Other
107 stars 25 forks source link

Diacritics and spelling errors #17

Closed IndrajeetPatil closed 5 years ago

IndrajeetPatil commented 5 years ago

If I have words with accented characters, e.g. moiré (as in "moiré vibrations"), then running

spelling::spell_check_files(path = list.files(pattern = ".Rmd"),
                            lang = 'en-US'

marks this as a spelling error: moirÃ.

Any possibility of avoiding this?

jeroen commented 5 years ago

Hmm it seems to work here. Are you on Windows? Please show your sessionInfo().

jeroen commented 5 years ago

@maelle do you see this problem as well ?

IndrajeetPatil commented 5 years ago
options(width = 200)
devtools::session_info()
#> - Session info ---------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
#>  setting  value                       
#>  version  R version 3.5.1 (2018-07-02)
#>  os       Windows 10 x64              
#>  system   x86_64, mingw32             
#>  ui       RTerm                       
#>  language (EN)                        
#>  collate  English_United States.1252  
#>  ctype    English_United States.1252  
#>  tz       America/New_York            
#>  date     2018-10-09                  
#> 
#> - Packages -------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
#>  package     * version     date       lib source                            
#>  assertthat    0.2.0       2017-04-11 [1] CRAN (R 3.5.0)                    
#>  backports     1.1.2       2017-12-13 [1] CRAN (R 3.5.0)                    
#>  base64enc     0.1-3       2015-07-28 [1] CRAN (R 3.5.0)                    
#>  callr         3.0.0       2018-08-24 [1] CRAN (R 3.5.1)                    
#>  cli           1.0.1       2018-09-25 [1] CRAN (R 3.5.1)                    
#>  crayon        1.3.4       2018-09-26 [1] Github (r-lib/crayon@3e751fb)     
#>  debugme       1.1.0       2017-10-22 [1] CRAN (R 3.5.0)                    
#>  desc          1.2.0       2018-05-01 [1] CRAN (R 3.5.0)                    
#>  devtools      1.13.6.9000 2018-09-23 [1] Github (r-lib/devtools@74df201)   
#>  digest        0.6.17      2018-09-12 [1] CRAN (R 3.5.1)                    
#>  evaluate      0.11        2018-07-17 [1] CRAN (R 3.5.1)                    
#>  fs            1.2.6       2018-08-23 [1] CRAN (R 3.5.1)                    
#>  glue          1.3.0       2018-09-17 [1] Github (tidyverse/glue@4e74901)   
#>  htmldeps      0.1.1       2018-09-17 [1] Github (rstudio/htmldeps@c1023e0) 
#>  htmltools     0.3.6       2017-04-28 [1] CRAN (R 3.5.0)                    
#>  knitr         1.20.12     2018-08-13 [1] local                             
#>  magrittr      1.5         2014-11-22 [1] CRAN (R 3.5.0)                    
#>  memoise       1.1.0       2017-04-21 [1] CRAN (R 3.5.0)                    
#>  pkgbuild      1.0.1.9000  2018-10-01 [1] Github (r-lib/pkgbuild@446d70c)   
#>  pkgload       1.0.0       2018-09-17 [1] Github (r-lib/pkgload@7771d78)    
#>  prettyunits   1.0.2       2015-07-13 [1] CRAN (R 3.5.0)                    
#>  processx      3.2.0       2018-08-16 [1] CRAN (R 3.5.1)                    
#>  ps            1.1.0       2018-08-10 [1] CRAN (R 3.5.1)                    
#>  R6            2.3.0       2018-10-04 [1] CRAN (R 3.5.1)                    
#>  Rcpp          0.12.19     2018-10-01 [1] CRAN (R 3.5.1)                    
#>  remotes       1.1.1.9000  2018-09-23 [1] Github (r-lib/remotes@5a07ad2)    
#>  rlang         0.2.2       2018-08-16 [1] CRAN (R 3.5.1)                    
#>  rmarkdown     1.10.13     2018-09-17 [1] Github (rstudio/rmarkdown@df4ec91)
#>  rprojroot     1.3-2       2018-01-03 [1] CRAN (R 3.5.0)                    
#>  sessioninfo   1.1.0       2018-09-25 [1] CRAN (R 3.5.1)                    
#>  stringi       1.2.4       2018-07-20 [1] CRAN (R 3.5.1)                    
#>  stringr       1.3.1       2018-05-10 [1] CRAN (R 3.5.0)                    
#>  testthat      2.0.0       2017-12-13 [1] CRAN (R 3.5.0)                    
#>  usethis       1.4.0.9000  2018-09-23 [1] Github (r-lib/usethis@1e3c6a6)    
#>  withr         2.1.2       2018-03-15 [1] CRAN (R 3.5.0)                    
#>  xfun          0.3         2018-07-06 [1] CRAN (R 3.5.1)                    
#>  yaml          2.2.0       2018-07-25 [1] CRAN (R 3.5.1)                    
#> 
#> [1] C:/Users/inp099/Documents/R/win-library/3.5
#> [2] C:/Program Files/R/R-3.5.1/library

Created on 2018-10-09 by the reprex package (v0.2.1)

jeroen commented 5 years ago

Thank you! Can you confirm this is fixed in the devel version?

remotes::install_github("ropensci/spelling")
dpprdan commented 5 years ago

For me, moiré gets marked as a spelling error (in en-US), but correctly as moiré not as moirÃ. I am on Windows with cp1252 native encoding, as well.

jeroen commented 5 years ago

Yes that is expected. It seems moiré is not part of the standard English dictionaries.