nanhung commented 5 years ago

Hi, I add a small piece of function to improve the UX in spell_check_files(). The improvement can let user directly check the working file in Rstudio without given the path name. The idea is from xaringan::infinite_moon_reader https://github.com/yihui/xaringan/blob/master/R/render.R

codecov-io commented 5 years ago

Codecov Report

Merging #19 into master will decrease coverage by 0.51%. The diff coverage is 28.57%.

@@            Coverage Diff             @@
##           master      #19      +/-   ##
==========================================
- Coverage   42.95%   42.43%   -0.52%     
==========================================
  Files           7        7              
  Lines         298      304       +6     
==========================================
+ Hits          128      129       +1     
- Misses        170      175       +5

Impacted Files	Coverage Δ
R/check-files.R	`54.68% <28.57%> (-3.94%)`	:arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 807f4b6...902a914. Read the comment docs.

jeroen commented 4 years ago

I'm not sure how you would use this. This would allow you to print potential spelling errors inside the markdown document itself?

I also don't really like that the behavior becomes dependent on which IDE the user has and the state of the IDE.

ropensci / spelling

Improve UX when using spell_check_files #19

Codecov Report