ropensci / spocc

Species occurrence data toolkit for R
https://docs.ropensci.org/spocc
Other
115 stars 27 forks source link

has_coords not functioning as expected #241

Open gmlmiller opened 3 years ago

gmlmiller commented 3 years ago

The has_coords argument appears to be pulling NA values in addition to actual coordinates when from = 'bison'. For example: occ('Allogona townsendiana', 'bison', limit=2000, has_coords=TRUE) returns 283 records, 150 of which have NA values for latitude and longitude.

Session Info ```- Session info -------------------------------------------------------------------------------------------------------- setting value version R version 4.0.5 (2021-03-31) os Windows 10 x64 system x86_64, mingw32 ui RStudio language (EN) collate English_Canada.1252 ctype English_Canada.1252 tz America/Chicago date 2021-04-30 - Packages ------------------------------------------------------------------------------------------------------------ package * version date lib source assertthat 0.2.1 2019-03-21 [1] CRAN (R 4.0.5) backports 1.2.1 2020-12-09 [1] CRAN (R 4.0.3) broom 0.7.6 2021-04-05 [1] CRAN (R 4.0.5) cachem 1.0.4 2021-02-13 [1] CRAN (R 4.0.5) callr 3.7.0 2021-04-20 [1] CRAN (R 4.0.5) cellranger 1.1.0 2016-07-27 [1] CRAN (R 4.0.5) cli 2.4.0 2021-04-05 [1] CRAN (R 4.0.5) colorspace 2.0-0 2020-11-11 [1] CRAN (R 4.0.5) conditionz 0.1.0 2019-04-24 [1] CRAN (R 4.0.5) crayon 1.4.1 2021-02-08 [1] CRAN (R 4.0.5) crul 1.1.0 2021-02-15 [1] CRAN (R 4.0.5) curl 4.3 2019-12-02 [1] CRAN (R 4.0.5) data.table 1.14.0 2021-02-21 [1] CRAN (R 4.0.5) DBI 1.1.1 2021-01-15 [1] CRAN (R 4.0.5) dbplyr 2.1.1 2021-04-06 [1] CRAN (R 4.0.5) desc 1.3.0 2021-03-05 [1] CRAN (R 4.0.5) devtools 2.4.0 2021-04-07 [1] CRAN (R 4.0.5) dplyr * 1.0.5 2021-03-05 [1] CRAN (R 4.0.5) ellipsis 0.3.1 2020-05-15 [1] CRAN (R 4.0.5) fansi 0.4.2 2021-01-15 [1] CRAN (R 4.0.5) fastmap 1.1.0 2021-01-25 [1] CRAN (R 4.0.5) forcats * 0.5.1 2021-01-27 [1] CRAN (R 4.0.5) fs 1.5.0 2020-07-31 [1] CRAN (R 4.0.5) generics 0.1.0 2020-10-31 [1] CRAN (R 4.0.5) ggplot2 * 3.3.3 2020-12-30 [1] CRAN (R 4.0.5) glue 1.4.2 2020-08-27 [1] CRAN (R 4.0.5) gtable 0.3.0 2019-03-25 [1] CRAN (R 4.0.5) haven 2.4.0 2021-04-14 [1] CRAN (R 4.0.5) hms 1.0.0 2021-01-13 [1] CRAN (R 4.0.5) httpcode 0.3.0 2020-04-10 [1] CRAN (R 4.0.5) httr 1.4.2 2020-07-20 [1] CRAN (R 4.0.5) jsonlite 1.7.2 2020-12-09 [1] CRAN (R 4.0.5) lattice 0.20-41 2020-04-02 [2] CRAN (R 4.0.5) lazyeval 0.2.2 2019-03-15 [1] CRAN (R 4.0.5) lifecycle 1.0.0 2021-02-15 [1] CRAN (R 4.0.5) lubridate 1.7.10 2021-02-26 [1] CRAN (R 4.0.5) magrittr 2.0.1 2020-11-17 [1] CRAN (R 4.0.5) mapproj 1.2.7 2020-02-03 [1] CRAN (R 4.0.5) maps 3.3.0 2018-04-03 [1] CRAN (R 4.0.5) memoise 2.0.0 2021-01-26 [1] CRAN (R 4.0.5) modelr 0.1.8 2020-05-19 [1] CRAN (R 4.0.5) munsell 0.5.0 2018-06-12 [1] CRAN (R 4.0.5) oai 0.3.0 2019-09-07 [1] CRAN (R 4.0.5) pillar 1.6.0 2021-04-13 [1] CRAN (R 4.0.5) pkgbuild 1.2.0 2020-12-15 [1] CRAN (R 4.0.5) pkgconfig 2.0.3 2019-09-22 [1] CRAN (R 4.0.5) pkgload 1.2.1 2021-04-06 [1] CRAN (R 4.0.5) plyr 1.8.6 2020-03-03 [1] CRAN (R 4.0.5) prettyunits 1.1.1 2020-01-24 [1] CRAN (R 4.0.5) processx 3.5.1 2021-04-04 [1] CRAN (R 4.0.5) ps 1.6.0 2021-02-28 [1] CRAN (R 4.0.5) purrr * 0.3.4 2020-04-17 [1] CRAN (R 4.0.5) R6 2.5.0 2020-10-28 [1] CRAN (R 4.0.5) rbison 1.0.0 2020-06-08 [1] CRAN (R 4.0.5) Rcpp 1.0.6 2021-01-15 [1] CRAN (R 4.0.5) readr * 1.4.0 2020-10-05 [1] CRAN (R 4.0.5) readxl 1.3.1 2019-03-13 [1] CRAN (R 4.0.5) rebird 1.2.0 2021-01-27 [1] CRAN (R 4.0.5) remotes 2.3.0 2021-04-01 [1] CRAN (R 4.0.5) reprex 2.0.0 2021-04-02 [1] CRAN (R 4.0.5) rgbif 3.5.2 2021-01-27 [1] CRAN (R 4.0.5) ridigbio 0.3.5 2017-02-16 [1] CRAN (R 4.0.5) rlang 0.4.10 2020-12-30 [1] CRAN (R 4.0.5) rprojroot 2.0.2 2020-11-15 [1] CRAN (R 4.0.5) rstudioapi 0.13 2020-11-12 [1] CRAN (R 4.0.5) rvertnet 0.8.0 2020-01-29 [1] CRAN (R 4.0.5) rvest 1.0.0 2021-03-09 [1] CRAN (R 4.0.5) scales 1.1.1 2020-05-11 [1] CRAN (R 4.0.5) sessioninfo 1.1.1 2018-11-05 [1] CRAN (R 4.0.5) sp 1.4-5 2021-01-10 [1] CRAN (R 4.0.5) spocc * 1.2.0 2021-01-05 [1] CRAN (R 4.0.5) stringi 1.5.3 2020-09-09 [1] CRAN (R 4.0.3) stringr * 1.4.0 2019-02-10 [1] CRAN (R 4.0.5) testthat 3.0.2 2021-02-14 [1] CRAN (R 4.0.5) tibble * 3.1.0 2021-02-25 [1] CRAN (R 4.0.5) tidyr * 1.1.3 2021-03-03 [1] CRAN (R 4.0.5) tidyselect 1.1.0 2020-05-11 [1] CRAN (R 4.0.5) tidyverse * 1.3.1 2021-04-15 [1] CRAN (R 4.0.5) tinytex 0.31 2021-03-30 [1] CRAN (R 4.0.5) triebeard 0.3.0 2016-08-04 [1] CRAN (R 4.0.5) urltools 1.7.3 2019-04-14 [1] CRAN (R 4.0.5) usethis 2.0.1 2021-02-10 [1] CRAN (R 4.0.5) utf8 1.2.1 2021-03-12 [1] CRAN (R 4.0.5) uuid 0.1-4 2020-02-26 [1] CRAN (R 4.0.3) vctrs 0.3.7 2021-03-29 [1] CRAN (R 4.0.5) wellknown 0.7.2 2021-01-07 [1] CRAN (R 4.0.5) whisker 0.4 2019-08-28 [1] CRAN (R 4.0.5) withr 2.4.2 2021-04-18 [1] CRAN (R 4.0.5) wk 0.4.1 2021-03-16 [1] CRAN (R 4.0.5) xfun 0.22 2021-03-11 [1] CRAN (R 4.0.5) xml2 1.3.2 2020-04-23 [1] CRAN (R 4.0.5) ```
sckott commented 3 years ago

thanks for your question @gmlmiller !

see the parameter description for has_coords https://docs.ropensci.org/spocc/reference/occ.html#arguments it does not support BISON - you can remove the NA's after getting the data back as an alternative