Accept multiple models - Githubissues

ropensci / stantargets

Reproducible Bayesian data analysis pipelines with targets and cmdstanr

https://docs.ropensci.org/stantargets

Other

47 stars 9 forks source link

Accept multiple models #9

Closed wlandau closed 3 years ago

wlandau commented 3 years ago

Prework

[x] I understand and agree to the code of conduct and contributing guidelines.
[x] If there is already a relevant issue, whether open or closed, comment on the existing thread instead of posting a new issue.
[x] New features take time and effort to create, and they take even more effort to maintain. So if the purpose of the feature is to resolve a struggle you are encountering personally, please consider first posting a "trouble" or "other" issue so we can discuss your use case and search for existing solutions first.

Proposal

It is often desirable to run multiple models on the same dataset. Let's accept multiple Stan files and turn them into the appropriate targets.

wlandau commented 3 years ago

This will be a set of breaking changes. I will rename the file argument stan_files and require it to be a character. Users will no longer be able to link it to an upstream tar_compile(). That's probably fine: if I redefine some targets for this issue, there should be no reason for users to define their own compilation targets.

wlandau commented 3 years ago

Other changes:

The _mcmc target should not depend on the _file target if it depends on the _lines target.
In the _rep() functions, if compile is "original", we should automatically add a tar_compile_raw() target upstream.

wlandau commented 3 years ago

Implemented in #11. Sorry about the breaking changes.