search

ropensci / stats19

R package for working with open road traffic casualty data from Great Britain
https://docs.ropensci.org/stats19
GNU General Public License v3.0
61 stars 19 forks source link

Remove multi-year functionality #214

Closed Robinlovelace closed 2 years ago

Robinlovelace commented 2 years ago

The changes for #99 were great for users but in hindsight made the package harder to maintain and more complicated than it needs to be.

In hindsight, I think that adding support for multiple years in download and getting the data was mission creep that puts the onus on us to know about all the various files and which ones can be safely combined. See #213 .

Robinlovelace commented 2 years ago

Example of this:

stats19:::check_year(2006)
Year not in range, changing to match 2005:2014 data
[1] 2005

That is now out of date and does not respond to updated tables. It leads to:

get_stats19(2006)
Year not in range, changing to match 2005:2014 data
Year not in range, changing to match 2005:2014 data
Year not in range, changing to match 2005:2014 data
No files of that type found for that year.
Error: No files of that type exist
Called from: find_file_name(years = year, type = type)
Robinlovelace commented 2 years ago

Latest from CRAN:

Thanks, we see:

Found the following (possibly) invalid URLs: URL: https://www.ncbi.nlm.nih.gov/pubmed/20007666 (moved to https://pubmed.ncbi.nlm.nih.gov/20007666/) From: inst/doc/blog.html inst/doc/stats19.html Status: 301 Message: Moved Permanently