Increase max download time, close #226

ropensci / stats19

R package for working with open road traffic casualty data from Great Britain

https://docs.ropensci.org/stats19

GNU General Public License v3.0

61 stars 19 forks source link

Increase max download time, close #226 #227

Closed Robinlovelace closed 11 months ago

agila5 commented 11 months ago

I don't understand the last part of the function (i.e. the if(!file.exists(...)) step) but, IMO, the new code is good! The only minor point would be setting on.exit(options(op), add = TRUE) instead of the current approach, but I think it doesn't make any difference here (since there are no previous call to on.exit()).

Robinlovelace commented 11 months ago

Thanks for the missing bracket! FYI I had a pretty bad hidden error, seems it can download only part of the .csv file and then fail leading to hidden incorrect data. This change will stop that, no need to try() it really but a definite guard against people getting incorrect data so will merge. Thanks Andrea!