ropensci / stats19

R package for working with open road traffic casualty data from Great Britain
https://docs.ropensci.org/stats19
GNU General Public License v3.0
61 stars 19 forks source link

Fix 235 #245

Closed layik closed 2 months ago

layik commented 2 months ago

Checks? Does this work with all types of objects supported by stats19?

closes #235

layik commented 2 months ago

ToDo:

I believe that is all needed to press "Ready for review"

Robinlovelace commented 2 months ago

Looking really good. Many thanks Layik :pray:

layik commented 2 months ago

On a Win instance the issue seems to be at a simple get_stats19 call, Windows complains about invalid parameter type which makes no sense.

Any help would be appreciated as the CI gives nothing to work with. EDIT: Windows R does not like

9. readr::cols(!!!col_types)

Quitting from lines 131-132 [dl2022-read] (stats19.Rmd)
Execution halted

Session

sessionInfo()
#> R version 4.4.1 (2024-06-14 ucrt)
#> Platform: x86_64-w64-mingw32/x64
#> Running under: Windows 10 x64 (build 19045)
#> 
#> Matrix products: default
#> 
#> 
#> locale:
#> [1] LC_COLLATE=English_United Kingdom.utf8 
#> [2] LC_CTYPE=English_United Kingdom.utf8   
#> [3] LC_MONETARY=English_United Kingdom.utf8
#> [4] LC_NUMERIC=C                           
#> [5] LC_TIME=English_United Kingdom.utf8    
#> 
#> time zone: Europe/London
#> tzcode source: internal
#> 
#> attached base packages:
#> [1] stats     graphics  grDevices utils     datasets  methods   base     
#> 
#> loaded via a namespace (and not attached):
#>  [1] digest_0.6.36     fastmap_1.2.0     xfun_0.46         glue_1.7.0       
#>  [5] knitr_1.48        htmltools_0.5.8.1 rmarkdown_2.27    lifecycle_1.0.4  
#>  [9] cli_3.6.3         reprex_2.1.1      withr_3.0.0       compiler_4.4.1   
#> [13] rstudioapi_0.16.0 tools_4.4.1       evaluate_0.24.0   yaml_2.3.9       
#> [17] rlang_1.1.4       fs_1.6.4

Created on 2024-07-29 with reprex v2.1.1

Robinlovelace commented 2 months ago

Awesome, thank you Layik!