ropensci / stplanr

Sustainable transport planning with R
https://docs.ropensci.org/stplanr
Other
420 stars 66 forks source link

Any idea why CRAN released Windows binnary "not available" ? #473

Closed rsbivand closed 2 years ago

rsbivand commented 2 years ago
Now https://cran.r-project.org/package=stplanr says: Windows binaries: r-devel: stplanr_0.8.5.zip, r-devel-UCRT: stplanr_0.8.5.zip, r-release: not available, r-oldrel: stplanr_0.8.5.zip

Any ideas?

Robinlovelace commented 2 years ago

Hi Roger, good question and now I'm not sure... Worth me emailing r-package-devel@r-project.org or CRAN? I hadn't spotted that, thanks for flagging.

rsbivand commented 2 years ago

Unsure - I suspect latency after the igraph update? pct is also not available for Windows release. I'm building a Windows binary for a course participant, should I post it here, (pct too)?

Robinlovelace commented 2 years ago

Maybe me pushing an incremental release is the quickest way forward... You should be able to get the Windows binary from r-universe.

Robinlovelace commented 2 years ago

This may solve the issue in the short term, just tested:

options(repos = c(
  ropensci = 'https://ropensci.r-universe.dev',
  CRAN = 'https://cloud.r-project.org'))
install.packages("stplanr")
Robinlovelace commented 2 years ago

I'm building a Windows binary for a course participant, should I post it here, (pct too)?

Good plan, important to raise the issue. I've just opened an issue there, thanks for the heads-up.

rsbivand commented 2 years ago

stplanr_0.8.5.zip pct_0.9.3.zip

I think latency from the igraph update is the reason, pushing both CRAN and packages depending on igraph to wait for current binaries. I don't think the universe is necessarily robust, even though no less robust than my builds Both + CRAN use the same tool train, even generating MD5 keys.

Robinlovelace commented 2 years ago

Looks like it is to do with igraph and it looks like the issue remains: https://github.com/igraph/rigraph/issues/489

Robinlovelace commented 2 years ago

Plan: try to make stplanr Suggest but not Import igraph.

Robinlovelace commented 2 years ago

After https://github.com/ropensci/stplanr/pull/475 you now get, for example:

> library(stplanr)
> rnet <- rnet_breakup_vertices(stplanr::osm_net_example)
> rnet$group <- rnet_group(rnet)
You must install igraph for this function to work

If you don't have igraph.

Robinlovelace commented 2 years ago

Update: stplanr no longer Imports igraph :tada: planning to submit to CRAN now...

Robinlovelace commented 2 years ago

Fixed now by the looks: https://cran.r-project.org/bin/windows/contrib/4.1/stplanr_0.8.5.zip

I realised that after submitting the patched version, will assume the binary will build OK. Closing this for now. Not Importing igraph is a good thing in any case IMO so this issue will lead to good things. Hopefully...