search

ropensci / stplanr

Sustainable transport planning with R
https://docs.ropensci.org/stplanr
Other
417 stars 66 forks source link

CRAN checks #494

Closed Robinlovelace closed 2 years ago

Robinlovelace commented 2 years ago

Email from CRAN:

Please see the problems shown on https://cran.r-project.org/web/checks/check_results_stplanr.html.

Please correct before 2022-09-01 to safely retain your package on CRAN.

Robinlovelace commented 2 years ago

Heads-up @mpadge I think this is the cause:

https://github.com/ropensci/stplanr/blob/a417dbd7e83d61e52286eb3c90647262f920c52d/R/route.R#L206-L211

According to the NEWS for {dodgr}, match_pts_to_graph() renamed to match_pts_to_verts().

Plan: remove support for dodgr for now and revisit when we it's safe to assume most people have updated to the latest version.

mpadge commented 2 years ago

@Robinlovelace argh, so sorry about that. Yes, i renamed match_points_to_graph -> match_points_to_verts. I also checked all hard dependencies, but neglected to look at soft deps, so missed stplanr. Please accept my humble apologies on that one!

Ironically, that was done to properly address what was originally an stplanr issue (https://github.com/ropensci/stplanr/issues/331) which led to https://github.com/ATFutures/dodgr/issues/103, which has now been addressed. "match points to graph" is what the function now does - a proper, super efficient and entirely geometric matching based on line intersections. The previous version was just a cheap vertex matching algorithm, hence the rename. Anyway, sorry.

Robinlovelace commented 2 years ago

Awesome and no worries Mark. Good news: I've resubmitted #496 to CRAN, let's see what happens. V. cool stuff so keen to keep the dodgr soft dep.