search

ropensci / stplanr

Sustainable transport planning with R
https://docs.ropensci.org/stplanr
Other
419 stars 66 forks source link

test on 3km #523

Closed wangzhao0217 closed 1 year ago

Robinlovelace commented 1 year ago

Currently checking out the code with 

git checkout -b wangzhao0217-520-add-arguments-to-rnet_merge-preventing-sideroads-getting-values-of-main-roads 520-add-arguments-to-rnet_merge-preventing-sideroads-getting-values-of-main-roads
git pull https://github.com/wangzhao0217/stplanr.git 520-add-arguments-to-rnet_merge-preventing-sideroads-getting-values-of-main-roads
wangzhao0217 commented 1 year ago

Hi @Robinlovelace , I am running the code now, it will take times, if you notice any issues pls let me know. The issue of the sideroad getting value from the main road still persists. I am still working on it.

Robinlovelace commented 1 year ago

Thanks Zhao, I've taken a look and the results look fine, but the high values on sideroads are still there, as shown below from the output of the new vignette:

image

Robinlovelace commented 1 year ago

Great, thanks. Keep up the good work.

I can see that https://github.com/wangzhao0217/stplanr/blob/520-add-arguments-to-rnet_merge-preventing-sideroads-getting-values-of-main-roads/vignettes/merging-route-networks%203km.Rmd

is currently the same as https://github.com/ropensci/stplanr/blob/master/vignettes/merging-route-networks.Rmd

Feel free to tag me when you want me to take a look.

Robinlovelace commented 1 year ago

Note: I've now merged this PR https://github.com/ropensci/stplanr/pull/521

If you can fix the issues that cause GitHub Actions to fail that would be amazing :pray: