Add angle as filter - Githubissues

ropensci / stplanr

Sustainable transport planning with R

https://docs.ropensci.org/stplanr

Other

416 stars 66 forks source link

Add angle as filter #529

Closed wangzhao0217 closed 10 months ago

wangzhao0217 commented 10 months ago

Hi Robin, Sorry I forgot to create the PR to let you review. Please have a look at this latest version with the following changes:

The angle mask is moved to rnet_join function as an argument, rnet_merge function is unchanged.
I tried to use the angle_diff function to replace calculate_angle/get_vector, but the results do not look quite right and are running slow (It may not be caused by the angle_diff function, but rather by the way I am using it.).

Here is the result.

Robinlovelace commented 10 months ago

Looks good, thanks @wangzhao0217 . Problem: GitHub Actions are failing. Can you test on this branch with

devtools::check()

If you pull down the latest version from the master branch you can test it works: please confirm devtools::check() works on the master branch, that should help debug any issues that are making the actions fail, as illustrated by the red x symbols above.

Robinlovelace commented 10 months ago

Update on this: I've had a look to try to diagnose the issue. It seems that you are calling functions from the {devtools} package in the vignette. Can you try removing reference to the package in the vignetter, or at least setting eval=FALSE in the relevant code chunk?

See here: https://github.com/ropensci/stplanr/actions/runs/6171414373/job/16749592822#step:6:46

Robinlovelace commented 10 months ago

Hi @wangzhao0217 here's another suggestion that should be a quick fix to get actions passing:

devtools::document()

Robinlovelace commented 10 months ago

Closed in favour of #530