bug in the rnet_merge function when defining the funs

[wangzhao0217]

when set funs <- Null or via

name_list <- names(rnet_y)
# Initialize an empty list
funs <- list()
# Loop through each name and assign it a function based on specific conditions
for (name in name_list) {
  if (name == "geometry") {
    next  # Skip the current iteration
  } else if (name %in% c("Gradient", "Quietness")) {
    funs[[name]] <- mean
  } else {
    funs[[name]] <- sum
  }
}

This error will pop up

rnet_merged = rnet_merge(rnet_x, rnet_y, dist = 20, segment_length = 10, fun$ st_as_s2(): dropping Z and/or M coordinate st_as_s2(): dropping Z and/or M coordinate Joining with by = join_by(identifier) |++++++++++++++++++++++++++++++++++++++++++++++++++| 100% elapsed=06m 37s New names: • all_fastest_bicycle_ebike -> all_fastest_bicycle_ebike...3 • all_fastest_bicycle_go_dutch -> all_fastest_bicycle_go_dutch...4 • all_fastest_bicycle_ebike -> all_fastest_bicycle_ebike...5 • all_fastest_bicycle_go_dutch -> all_fastest_bicycle_go_dutch...6 • all_quietest_bicycle_ebike -> all_quietest_bicycle_ebike...8 • all_quietest_bicycle_go_dutch -> all_quietest_bicycle_go_dutch...9 • all_quietest_bicycle_ebike -> all_quietest_bicycle_ebike...10 • all_quietest_bicycle_go_dutch -> all_quietest_bicycle_go_dutch...11 • commute_fastest_bicycle_ebike -> commute_fastest_bicycle_ebike...13 • commute_fastest_bicycle_go_dutch -> commute_fastest_bicycle_go_dutch...14 • commute_fastest_bicycle_ebike -> commute_fastest_bicycle_ebike...15 • commute_fastest_bicycle_go_dutch -> commute_fastest_bicycle_go_dutch...16 • commute_quietest_bicycle_ebike -> commute_quietest_bicycle_ebike...18 • commute_quietest_bicycle_go_dutch -> commute_quietest_bicycle_go_dutch...19 • commute_quietest_bicycle_ebike -> commute_quietest_bicycle_ebike...20 • commute_quietest_bicycle_go_dutch -> commute_quietest_bicycle_go_dutch...21 • primary_fastest_bicycle_ebike -> primary_fastest_bicycle_ebike...23 • primary_fastest_bicycle_go_dutch -> primary_fastest_bicycle_go_dutch...24 • primary_fastest_bicycle_ebike -> primary_fastest_bicycle_ebike...25 • primary_fastest_bicycle_go_dutch -> primary_fastest_bicycle_go_dutch...26 • primary_quietest_bicycle_ebike -> primary_quietest_bicycle_ebike...28 • primary_quietest_bicycle_go_dutch -> primary_quietest_bicycle_go_dutch...29 • primary_quietest_bicycle_ebike -> primary_quietest_bicycle_ebike...30 • primary_quietest_bicycle_go_dutch -> primary_quietest_bicycle_go_dutch...31 • secondary_fastest_bicycle_ebike -> secondary_fastest_bicycle_ebike...33 • secondary_fastest_bicycle_go_dutch -> secondary_fastest_bicycle_go_dutch...34 • secondary_fastest_bicycle_ebike -> secondary_fastest_bicycle_ebike...35 • secondary_fastest_bicycle_go_dutch -> secondary_fastest_bicycle_go_dutch...36 • secondary_quietest_bicycle_ebike -> secondary_quietest_bicycle_ebike...38 • secondary_quietest_bicycle_go_dutch -> secondary_quietest_bicycle_go_dutch...39 • secondary_quietest_bicycle_ebike -> secondary_quietest_bicycle_ebike...40 • secondary_quietest_bicycle_go_dutch -> secondary_quietest_bicycle_go_dutch...41 Joining with by = join_by(identifier) st_as_s2(): dropping Z and/or M coordinate Error in structure(): ! Assigned data value must be compatible with existing data. ✖ Existing data has 5168 rows. ✖ Assigned data has 0 rows. ℹ Only vectors of size 1 are recycled. Caused by error in vectbl_recycle_rhs_rows(): ! Can't recycle input of size 0 to size 5168.

when setting funs as funs = list( all_fastest_bicycle = sum,

all_fastest_bicycle_ebike = sum,

# all_fastest_bicycle_go_dutch = sum, 
all_quietest_bicycle = sum, 
# all_quietest_bicycle_ebike = sum, 
# all_quietest_bicycle_go_dutch = sum, 
commute_fastest_bicycle = sum, 
# commute_fastest_bicycle_ebike = sum, 
# commute_fastest_bicycle_go_dutch = sum, 
commute_quietest_bicycle = sum, 
# commute_quietest_bicycle_ebike = sum, 
# commute_quietest_bicycle_go_dutch = sum, 
primary_fastest_bicycle = sum, 
# primary_fastest_bicycle_ebike = sum, 
# primary_fastest_bicycle_go_dutch = sum, 
primary_quietest_bicycle = sum, 
# primary_quietest_bicycle_ebike = sum, 
# primary_quietest_bicycle_go_dutch = sum, 
secondary_fastest_bicycle = sum, 
# secondary_fastest_bicycle_ebike = sum, 
# secondary_fastest_bicycle_go_dutch = sum, 
secondary_quietest_bicycle = sum, 
# secondary_quietest_bicycle_ebike = sum, 
# secondary_quietest_bicycle_go_dutch = sum, 
Gradient = mean, 
Quietness = mean

) The rnet_merge function is executing successfully, and the uncommented columns in rnet_merged are displaying the expected results. However, an issue persists where the commented-out columns (such as all_fastest_bicycle_ebike, all_quietest_bicycle_ebike, etc.) are appearing in rnet_merged with inaccurate results.

Error stems from code:

  if (identical(fn, sum) && sum_flows) {
    res = rnetj_df %>%
      dplyr::group_by_at(1) %>%
      dplyr::summarise(dplyr::across(dplyr::matches(nm), function(x) sum(x * length_y)))
  } else {
    res = rnetj_df %>%
      dplyr::group_by_at(1) %>%
      dplyr::summarise(dplyr::across(dplyr::matches(nm), fn))
  }

[Robinlovelace]

Hey @wangzhao0217 I'm going to get a cup of tea and then will head up to double team this with you.

[wangzhao0217]

Hey @wangzhao0217 I'm going to get a cup of tea and then will head up to double team this with you.

Hi Robin, pls have a look at the pull request, Does that make sense to you change dplyr::matches to dplyr::all_of

[Robinlovelace]

Thanks Zhao and great fix!