ropensci / taxa

taxonomic classes for R
https://docs.ropensci.org/taxa
Other
48 stars 12 forks source link

CRAN release 2.1 #155

Closed zachary-foster closed 6 years ago

zachary-foster commented 6 years ago

I think I have made all the changes I want for a minor version release. Its actually been a while and a lot of changes have accumulated. Here is the news for this version so far:

Improvements

Changes

Bug fixes

@sckott, is there anything you want done before another release to CRAN? I can think of the folllowing:

anything else? Thanks

sckott commented 6 years ago

not that I can think of, though should these two issues https://github.com/ropensci/taxa/milestone/3?closed=1 be included in this milestone since they are closed ?

zachary-foster commented 6 years ago

The one about how to handle filtering datasets with no taxon IDs is done. datasets without valid taxon IDs are not modified by filter_taxa.

The other one will be implemented as discussed in #139, but I want to for the next release for that since it will involve changing a lot of code.

They can be included in this milestone, although I have not been using this milestone until very recently so there are probably a lot of other issues with no milestone that were closed but will be implemented in this release.

sckott commented 6 years ago

okay, just trying to check if any closed issues should go in here that didn't get this milestone label.

zachary-foster commented 6 years ago

Ahh ok, I will go through the recently closed ones and add them to this milestone

zachary-foster commented 6 years ago

I think everything is read for a release now. @sckott, do you need to email CRAN about the change of maintainer or did you already do that?

sckott commented 6 years ago

already did, see email from Feb 1

Then please resubmit with yourself as the maintakner citing this message in the submisison comments.

zachary-foster commented 6 years ago

For some reason I cant find that email. Can you forward it to me please?

sckott commented 6 years ago

done

zachary-foster commented 6 years ago

got it, thanks