search

ropensci / taxa

taxonomic classes for R
https://docs.ropensci.org/taxa
Other
48 stars 12 forks source link

Parsing vignette #161

Open zachary-foster opened 6 years ago

zachary-foster commented 6 years ago

I have been working on a vignette for getting data into the taxa classes. It only covers taxmap so far, but I would like to extend it to other classes as well, but I started with taxmap since it is the most developed so far and the most confusing as well.

For the taxonomy, just adding a as_taxonomy.taxmap function will allow the taxmap parsers to be used to get taxonomy objects.

For some of the other classes, I want to get #139 done first so I can use it as infrastructure to refactor some of the constructor code.

@sckott, can you take a look at the current parsing vignette and see what you think?

https://github.com/ropensci/taxa/blob/master/vignettes/taxa-parsing.Rmd

What do you think of including it in the next CRAN release, even though it is not done? Anything unclear? I get a lot of questions about how to parse data in metacoder and I would like to be able to point people somewhere.

Thanks!

sckott commented 6 years ago

Looks good to me.

I can see how suppressing progress bars would help (#162)

I think it's good t include, it's good to have placeholders for the other classes so folks know we are meaning to get around to it.

zachary-foster commented 6 years ago

Thanks! I will see if I can get a decent solution to the progress bars in before submitting to CRAN.