search

ropensci / taxa

taxonomic classes for R
https://docs.ropensci.org/taxa
Other
48 stars 12 forks source link

Added basic tests for `taxmap` #33

Closed zachary-foster closed 7 years ago

zachary-foster commented 7 years ago

Description

Added tests for taxmap. More should be added, but the major functionality and obvious edge cases are tested. In particular, the sample_n_obs and sample_n_taxa need more tests since I am not sure yet about how the details of these functions should work; It might be best to remove some of the more confusing options.

Related Issue

Resolves #24

codecov-io commented 7 years ago

Codecov Report

Merging #33 into master will increase coverage by 48.86%. The diff coverage is 64.91%.

@@             Coverage Diff             @@
##           master      #33       +/-   ##
===========================================
+ Coverage    28.7%   77.56%   +48.86%     
===========================================
  Files          16       16               
  Lines         986     1012       +26     
===========================================
+ Hits          283      785      +502     
+ Misses        703      227      -476
Impacted Files Coverage Δ
R/taxmap--class.R 91.18% <100%> (+90.19%) :arrow_up:
R/taxmap--internal.R 72.65% <35.71%> (+32.65%) :arrow_up:
R/internal.R 93.54% <60%> (+93.54%) :arrow_up:
R/taxonomy--s3.R 33.33% <0%> (+5.55%) :arrow_up:
R/taxonomy--class.R 91.81% <0%> (+16.37%) :arrow_up:
R/taxmap--s3.R 45.71% <0%> (+45.71%) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 8485505...35a5ca1. Read the comment docs.

sckott commented 7 years ago

awesome, gotta get to writing some tests as well