Issue errors if a user tries to uses a `taxmap` option with `taxonomy` object

ropensci / taxa

taxonomic classes for R

https://docs.ropensci.org/taxa

Other

48 stars 12 forks source link

Issue errors if a user tries to uses a `taxmap` option with `taxonomy` object #47

Closed zachary-foster closed 7 years ago

zachary-foster commented 7 years ago

There are 4 functions that have been moved from taxmap to taxonomy:

[x] filter_taxa
[x] arrange_taxa
[x] sample_n_taxa
[x] sample_frac_taxa

These have a few options specific to taxmap. For the purposes of DRY, I will try to have the full functions in taxonomy and check the class used before allowing the options specific to taxmap to be used.

sckott commented 7 years ago

this is for first CRAN push, yes?

zachary-foster commented 7 years ago

I think so, I expect to have it done today. Now there is only one version of those functions in Taxonomy (not in Taxmap), so its actually a little less complicated than overwriting the functions in taxmap like I did originally. Just need to move things around and add some ifs and warnings.

sckott commented 7 years ago

okay, will mark with the milestone