Think about the best way to handle failed downloads

ropensci / taxa

taxonomic classes for R

https://docs.ropensci.org/taxa

Other

48 stars 12 forks source link

Think about the best way to handle failed downloads #90

Closed zachary-foster closed 6 years ago

zachary-foster commented 7 years ago

This applies to lookup_tax_data and extract_tax_data.

Currently, failed downloads are assigned to an "unknown" taxon with a warning, but I am not sure it works in all cases and if it maintains the correspondence between datasets and failed queries.

[x] Check failed "taxon_name" queries
[x] Check failed "seq_id" queries
[x] Check failed "taxon_id" queries
[x] Check that data sets maintain correspondence
[ ] add option to remove placeholders for failed downloads

zachary-foster commented 6 years ago

Instaed of adding an option to remove failed downloads, I said how to do it in the help.