ropensci / taxadb

:package: Taxonomic Database
https://docs.ropensci.org/taxadb
Other
43 stars 13 forks source link

Reviewer to do #64

Closed karinorman closed 4 years ago

karinorman commented 4 years ago

General

Reviewer 1

Reviewer 2

cboettig commented 4 years ago

Additionally, I think we need to tackle the versioning database thing. I can try to take a crack at that... in doing so, we might want to cut a new update of some of the backends as well now. I think there's newer COL and OTT releases already, and GBIF, ITIS, NCBI are rolling updates and could probably be updated.

quickly re database disconnect -- we do have td_disconnect() but it's not currently exported (and might need documentation). I also kinda recall that issue is particularly annoying for monetdblite which doesn't allow concurrent connections, (though I think we found a workaround at some point), and shouldn't matter so much once duckdb replaces monet...)

cboettig commented 4 years ago

Done. and versioning done too.