ropensci / taxadb

:package: Taxonomic Database
https://docs.ropensci.org/taxadb
Other
43 stars 13 forks source link

Warning message when calling get_ids #82

Closed dochvam closed 3 years ago

dochvam commented 3 years ago

Hi,

I've started getting a warning when using the get_ids function (or other "get" functions). The following is a reproducible example:

taxadb::get_ids("Toxostoma rufum", db = "itis")

which produces the following output:

[1] "ITIS:178627" Warning message: ORDER BY is ignored in subqueries without LIMIT i Do you need to move arrange() later in the pipeline or use window_order() instead?

I don't think this is actually impacting the results, which look fine.

Session info: R version 4.0.3 (2020-10-10) Platform: x86_64-w64-mingw32/x64 (64-bit) Running under: Windows 10 x64 (build 18363)

Matrix products: default

locale: [1] LC_COLLATE=English_United States.1252 LC_CTYPE=English_United States.1252
[3] LC_MONETARY=English_United States.1252 LC_NUMERIC=C
[5] LC_TIME=English_United States.1252

attached base packages: [1] stats graphics grDevices utils datasets methods base

other attached packages: [1] rgdal_1.5-19 sp_1.4-5 taxadb_0.1.0 forcats_0.5.0 stringr_1.4.0 dplyr_1.0.3
[7] purrr_0.3.4 readr_1.4.0 tidyr_1.1.2 tibble_3.0.6 ggplot2_3.3.3 tidyverse_1.3.0

cboettig commented 3 years ago

:+1: yup, confirmed. I think it's harmless but we can patch, probably by doing window_order() like it suggests or just skipping the arrange at all.