Incorporate remaining comments, from Naim and Karthik

ropensci / taxize

A taxonomic toolbelt for R

https://docs.ropensci.org/taxize

Other

268 stars 61 forks source link

Incorporate remaining comments, from Naim and Karthik #170

Closed sckott closed 11 years ago

sckott commented 11 years ago

Karthiks here: https://github.com/ropensci/taxize_/blob/dev_ms/inst/doc/taxize_KR.pdf

Naim's here: https://github.com/ropensci/taxize_/blob/dev_ms/inst/doc/taxize_withcode_plos_nm.pdf

eduardszoecs commented 11 years ago

Thanks for the comments! Just walked through and fixed most of them (see merge #172). Can you take a look at?

karthik commented 11 years ago

No problem! Hope it's useful. Cheers. :+1:

sckott commented 11 years ago

@EDiLD sure, you said most of them, are there any left to incorporate?

sckott commented 11 years ago

@EDiLD The changes look good. Are there any changes left to take care of from Naim and Karthik's comments?

eduardszoecs commented 11 years ago

@SChamberlain : @karthikram comments: Take a look at:

First, if you have more than a few names to lookup on a website, it can take quite a long time to enter each name, get data, and repeat for each species

Web APIs often define a number of ....

Some of the data sources taxize interacts with require authentication....

discussion data source

feedback in conclusion

@naims comments:

Introduction: catcher....

sckott commented 11 years ago

@EDiLD Okay, I'll take a look and finish off any changes