ropensci / taxize

A taxonomic toolbelt for R
https://docs.ropensci.org/taxize
Other
265 stars 58 forks source link

classification.colid should return submitted name #251

Closed eduardszoecs closed 10 years ago

eduardszoecs commented 10 years ago

Currently there is a different behaviour between methods... classification.uid returns the species name, classification.colid not.

> classification(get_uid('Baetis rhodani'))

Retrieving data for taxon 'Baetis rhodani'

$`189839`
                 name         rank
1  cellular organisms      no rank
2           Eukaryota superkingdom
3        Opisthokonta      no rank
4             Metazoa      kingdom
5           Eumetazoa      no rank
6           Bilateria      no rank
7         Protostomia      no rank
8           Ecdysozoa      no rank
9       Panarthropoda      no rank
10         Arthropoda       phylum
11        Mandibulata      no rank
12       Pancrustacea      no rank
13           Hexapoda   superclass
14            Insecta        class
15         Dicondylia      no rank
16          Pterygota      no rank
17        Palaeoptera     subclass
18      Ephemeroptera        order
19         Pisciforma     suborder
20           Baetidae       family
21             Baetis        genus
22     Baetis rhodani      species

attr(,"class")
[1] "classification"
attr(,"db")
[1] "ncbi"
Error in fetch(key) : lazy-load database '�' is corrupt
In addition: Warning message:
In fetch(key) : internal error -3 in R_decompress1
> classification(get_colid('Baetis rhodani'))

Retrieving data for taxon 'Baetis rhodani'

$`12576847`
           name        rank
1      Animalia     Kingdom
2    Arthropoda      Phylum
3       Insecta       Class
4 Ephemeroptera       Order
5     Baetoidea Superfamily
6      Baetidae      Family
7        Baetis       Genus

attr(,"class")
[1] "classification"
attr(,"db")
[1] "col"
eduardszoecs commented 10 years ago

Moreover, the message

More than one eolid found for taxon 'Onthophagus vitulus'! is not correct, since we are dealing with colid not eolid.

@sckott : Will work on this, this afternoon.

sckott commented 10 years ago

Cool, thanks @EDiLD

eduardszoecs commented 10 years ago

Fixed for colid and eolid. Did not check tpsid!

sckott commented 10 years ago

okay, should I?

eduardszoecs commented 10 years ago

Jupp, thanks.

sckott commented 10 years ago

ok

sckott commented 10 years ago

I think this is fixed, closing