CRAN errors - Githubissues

ropensci / taxize

A taxonomic toolbelt for R

https://docs.ropensci.org/taxize

Other

265 stars 59 forks source link

CRAN errors #65

Closed sckott closed 11 years ago

sckott commented 11 years ago

Looks like we have errors on three different platforms: see here

I thought that the tests were fine when we tested them, and it passed the windows check

This one doesn't make any sense: that is, it says it cannot find the function paste0, weird.

eduardszoecs commented 11 years ago

OK lets break them down:

r-release-macosx-ix86: Error comes from iucn_summary
r-release-windows-ix86+x86_64 is probably a Curl Error but only on 64bit systems (perhabs some server we were calling was down?)
r-oldrel-windows-ix86+x86_64 is an Error from get_genes_avail (paste0(..., collapse) is equivalent to paste(..., sep = "", collapse))

eduardszoecs commented 11 years ago

1) Don't know. Can you check (you are on a Mac machine?). 2) just try again 3) I think paste0 was established just 1 or 2 R versions ago... Since this was tested on R2.14.2 maybe paste0 isn`t there. So changing from paste0 to paste should solve the problem.

sckott commented 11 years ago

1) I am on a mac, and it passes just fine. It must be a a package or package version that I already have installed that is going wrong. 2) It does pass windows check every time I send it to the Windows checker. Seems like if it was one of the APIs we call that it would not still be failing - the cran check page continues to show ERROR. 3) Ok, will switch to paste

sckott commented 11 years ago

1) checked on R-release (I am usually on R-patched), and it works fine, still not sure why this error is happening. 3) changed from paste0 to paste, hopefully this will fix it

sckott commented 11 years ago

I'm getting errors on the iplant_tnrsmatch function now, their servers are down.

By the way, I wonder if we can build in error catching for every API service so taxize passes checks when any of the API servers are down. For example, could we wrap getURL/getForm/etc. calls in try or tryCatch or something else that will recognize that the API service is down, and that it's not our code per se. Then we can spit out a meaningful error message. If we do this, it would be nice to build in a way for tests to pass even when the API service is down.

sckott commented 11 years ago

The API for the iplant_tnrsmatch function is back up...

sckott commented 11 years ago

v0.0.2 submitted, closing this