search

ropensci / taxize

A taxonomic toolbelt for R
https://docs.ropensci.org/taxize
Other
267 stars 60 forks source link

R CMD Check cannot run via GitHub Actions because of untagged version #924

Open cpauvert opened 9 months ago

cpauvert commented 9 months ago

Hello, thanks a lot for developing and maintaining this resource! I noticed that the Github Actions for checking this R package are always failing in a day or so (see screenshot or a recent run) and this is likely due to a change in https://github.com/r-lib/actions/issues/639

Screenshot 2023-12-20 at 14-18-20 make get_wormsid not crash when rows specified and query not found · ropensci_taxize@d067035

Since the end of 2022, the following line:

https://github.com/ropensci/taxize/blob/d067035e756a4103ab95407d5603a967fb8b0703/.github/workflows/R-CMD-check.yaml#L31

should use the tagged version of the action as in the {targets} package for example. and as shown below.

    - uses: r-lib/actions/setup-r@v2

Changing only this line should be a quick fix, but the overall workflow might need a dust-off, I wanted to submit a PR, but unfortunately there are a couple of API tokens/keys that are necessary (e.g., IUCN) that I do not have and cannot obtain (error 403). Therefore I cannot test the Github Actions properly. I'll try again at the beginning of the year and hope to help fix this issue and contribute to your ongoing effort.

Best,

bschilder commented 9 months ago

If interested, this may be a good opportunity to try rworkfllows, which is a centrally maintained GH Action (so you don't have to worry about fixing it yourself).

https://github.com/neurogenomics/rworkflows

zachary-foster commented 9 months ago

Thanks for the info @cpauvert and @bschilder! I don't have much experience with Github actions, so I will have to read up on it a bit and get back to this. In the mean time, I will implement the change suggested by @cpauvert.

bschilder commented 9 months ago

No worries @zachary-foster, if you like I could make a PR and get it set up for you. For context, rworkflows was designed to abstract away a lot of the technical details of setting up GHA so that you don't have to worry about it too much on your end.

zachary-foster commented 8 months ago

@bschilder Thank for the offer! Sure, a PR would be great!

cpauvert commented 8 months ago

Thanks @zachary-foster for considering this and for the last commit, it seems that something is still off unfortunately as the runs on macOS and windows are still failing..

Thanks @bschilder, I did not know about rworkflows and it could be a good new start!

Do you also have a 403 error when trying to get the IUCN API key at https://apiv3.iucnredlist.org/api/v3/token?

zachary-foster commented 8 months ago

Yes, I also get a 403 error at that link.

bschilder commented 8 months ago

@zachary-foster @cpauvert just wanted to let you know I've made the PR for rworkflows here:

926