search

ropensci / taxizedb

Tools for Working with Taxonomic SQL Databases
Other
30 stars 7 forks source link

Fix #21 #22

Closed arendsee closed 6 years ago

arendsee commented 6 years ago

Description

Fix #21, death on name duplicates

Related Issue

Fix #21

Example

Now this doesn't explode:

name2taxid(c('pig', 'pig'))
codecov-io commented 6 years ago

Codecov Report

Merging #22 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #22   +/-   ##
=======================================
  Coverage   68.95%   68.95%           
=======================================
  Files          11       11           
  Lines         496      496           
=======================================
  Hits          342      342           
  Misses        154      154
Impacted Files Coverage Δ
R/ap_name2taxid.R 94.28% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6ab2032...be4ebd8. Read the comment docs.

sckott commented 6 years ago

looks good, thanks