Closed levisc8 closed 4 years ago
Merging #5 into master will increase coverage by
0.09%
. The diff coverage is90.00%
.
@@ Coverage Diff @@
## master #5 +/- ##
==========================================
+ Coverage 94.64% 94.74% +0.09%
==========================================
Files 28 27 -1
Lines 1102 1160 +58
==========================================
+ Hits 1043 1099 +56
- Misses 59 61 +2
Impacted Files | Coverage Δ | |
---|---|---|
R/levels.R | 100.00% <ø> (ø) |
|
R/summary.R | 89.90% <83.33%> (-1.27%) |
:arrow_down: |
R/Extract.R | 100.00% <100.00%> (ø) |
|
R/subset.R | 100.00% <0.00%> (ø) |
|
R/replace_x.R | 100.00% <0.00%> (ø) |
|
R/merge_taxa.R | 100.00% <0.00%> (ø) |
|
R/get_children.R | 100.00% <0.00%> (ø) |
|
R/taxon_relations.R | 100.00% <0.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 2cc4c20...2440227. Read the comment docs.
Issues with devtools::test()
are solved. Thanks!
As discussed in ropensci/software-review#233, fixes file paths in a few unit tests. I ran
devtools::test()
,devtools::check()
, anddevtools::check_built()
(from the0_check.R
script) and these all passed w/ no errors, warnings or notes.The oldrel build on Travis is failing because it cannot install the
XML
package, and never actually reaches the check stage. Apparentlytaxa
has some dependency that itself depends onXML
(based on the travis log, I think it'srentrez
), and XML now requires R >= 4.0. I have no idea how to deal with this, except maybe specify an older version oftaxa
in the Description, or bump your minimum R version requirement and no longer support R < 4.0.Note that the file name for
Podocarpus_2020-01-10.rda
is now hard-coded into the unit testtest-loadlast,R
. If you make a newer version of this file, you'll need to modify the test accordingly I think.Let me know if you have any issues w/ this - I don't think using Eclipse will cause any issues w/ the new code, but I also haven't attempted to test it with a different IDE.