search

ropensci / tesseract

Bindings to Tesseract OCR engine for R
https://docs.ropensci.org/tesseract
245 stars 26 forks source link

fix #67 #69

Closed pachadotdev closed 3 months ago

jeroen commented 3 months ago

We can probably fix the warning by using int i instead of size_t i in the for loop.

pachadotdev commented 3 months ago

We can probably fix the warning by using int i instead of size_t i in the for loop.

I edited that!

it is practically the same, the number of languages will never create an integer overflow and that the performance impact is zero

jeroen commented 3 months ago

I meant that that way you can keep the langs.size() in the loop and keep the diff very minimal.

pachadotdev commented 3 months ago

I meant that that way you can keep the langs.size() in the loop and keep the diff very minimal.

yes, my PR saves 1 duplicated computation

pachadotdev commented 3 months ago

I meant that that way you can keep the langs.size() in the loop and keep the diff very minimal.

done

jeroen commented 3 months ago

Can you fix the merge conflict

pachadotdev commented 3 months ago

Can you fix the merge conflict

done, thx!