search

ropensci / textreuse

Detect text reuse and document similarity
https://docs.ropensci.org/textreuse
197 stars 33 forks source link

Operation with unevaluated n_call #80

Closed quartin closed 5 years ago

quartin commented 7 years ago

When iterating on the number of words in each n-gram, I discovered that TextReuseTextDocument returns an error when n is a variable:

 Error in n_call + 1 : non-numeric argument to binary operator

This solves the bug. I also added a quick test.

codecov-io commented 7 years ago

Codecov Report

Merging #80 into master will not change coverage. The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##           master      #80   +/-   ##
=======================================
  Coverage   90.27%   90.27%           
=======================================
  Files          25       25           
  Lines         720      720           
=======================================
  Hits          650      650           
  Misses         70       70
Impacted Files Coverage Δ
R/TextReuseTextDocument.R 93.18% <100%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 6a81b41...41a4ac6. Read the comment docs.

mrwunderbar666 commented 1 year ago

Why was this pull request not merged?