Closed boshek closed 5 years ago
These timezones are not daylight savings independent:
library(tidyhydat) unique(allstations$station_tz) #> [1] "America/Moncton" "America/New_York" #> [3] "America/Halifax" "America/Glace_Bay" #> [5] "America/Toronto" "America/Thunder_Bay" #> [7] "America/Goose_Bay" "America/St_Johns" #> [9] "America/Winnipeg" "America/Edmonton" #> [11] "America/Regina" "America/Atikokan" #> [13] "America/Rainy_River" "America/Rankin_Inlet" #> [15] "America/Yellowknife" "America/Vancouver" #> [17] "America/Dawson_Creek" "America/Whitehorse" #> [19] "America/Creston" "America/Dawson" #> [21] "America/Fort_Nelson" "America/Inuvik" #> [23] "America/Cambridge_Bay" "America/Iqaluit" #> [25] "America/Resolute" "America/Chicago" #> [27] "America/Detroit" "America/Blanc-Sablon" #> [29] "America/Denver" "America/Swift_Current" #> [31] "America/Yakutat" "America/Juneau" #> [33] "America/Sitka" "America/Los_Angeles" #> [35] "America/Anchorage" "America/Pangnirtung"
Rather they should labelled as:
grep("Etc", OlsonNames(), value = TRUE) #> [1] "Etc/GMT" "Etc/GMT-0" "Etc/GMT-1" "Etc/GMT-10" #> [5] "Etc/GMT-11" "Etc/GMT-12" "Etc/GMT-13" "Etc/GMT-14" #> [9] "Etc/GMT-2" "Etc/GMT-3" "Etc/GMT-4" "Etc/GMT-5" #> [13] "Etc/GMT-6" "Etc/GMT-7" "Etc/GMT-8" "Etc/GMT-9" #> [17] "Etc/GMT+0" "Etc/GMT+1" "Etc/GMT+10" "Etc/GMT+11" #> [21] "Etc/GMT+12" "Etc/GMT+2" "Etc/GMT+3" "Etc/GMT+4" #> [25] "Etc/GMT+5" "Etc/GMT+6" "Etc/GMT+7" "Etc/GMT+8" #> [29] "Etc/GMT+9" "Etc/GMT0" "Etc/Greenwich" "Etc/UCT" #> [33] "Etc/Universal" "Etc/UTC" "Etc/Zulu"
Created on 2018-10-09 by the reprex package (v0.2.1)
This could be done here: https://github.com/ropensci/tidyhydat/blob/6cb8a871dbc2c7f0560f6f8138c375109994741e/data-raw/HYDAT_internal_data/process_internal_data.R#L9-L20
These timezones are not daylight savings independent:
Rather they should labelled as:
Created on 2018-10-09 by the reprex package (v0.2.1)
This could be done here: https://github.com/ropensci/tidyhydat/blob/6cb8a871dbc2c7f0560f6f8138c375109994741e/data-raw/HYDAT_internal_data/process_internal_data.R#L9-L20