ropensci / tidyhydat

An R package to import Water Survey of Canada hydrometric data and make it tidy
https://docs.ropensci.org/tidyhydat
Apache License 2.0
70 stars 19 forks source link

Fix closeAllConnections #153

Closed boshek closed 3 years ago

boshek commented 3 years ago

From CRAN:

These package have code calling

closeAllConnections()

which seems a very bad idea in package code, as indeed it will close all user connections etc, and not just the ones opened by the package.

Can you please fix "as necessary", and ensure your package code only closes connections it also opened?

Please fix before 2021-06-08 to safely retain your package on CRAN.

Fix here: https://github.com/ropensci/tidyhydat/blob/2c177aec31d5e8fe296b5336b786b01bb83841c9/R/download.R#L42