search

ropensci / tidyhydat

An R package to import Water Survey of Canada hydrometric data and make it tidy
https://docs.ropensci.org/tidyhydat
Apache License 2.0
70 stars 19 forks source link

Update download_hydat to have an option to bypass the keypress question #165

Closed rchlumsk closed 2 years ago

rchlumsk commented 2 years ago

Small update to download_hydat to add a parameter ask, which will bypass the keypress question and proceed directly to the download of HYDAT if ask=FALSE. Default ask=TRUE makes no change to the existing workflow with the function.

Implemented to have an option for bypassing the keypress when using download_hydat in another function or other situations when the keypress is not ideal.

rchlumsk commented 2 years ago

Thanks for the suggestions, all make sense! I've added a news item but I am not sure how you would like the test to look or what it would check, could you please more insight on that? I haven't done much with testthat tests myself but happy to give it a shot if you provide a few more parameters. Thanks.

boshek commented 2 years ago

Actually I don't it is worth the hassle of testing this. Looks really good to me to close #165. Thanks for this.