Closed rchlumsk closed 2 years ago
Thanks for the suggestions, all make sense! I've added a news item but I am not sure how you would like the test to look or what it would check, could you please more insight on that? I haven't done much with testthat
tests myself but happy to give it a shot if you provide a few more parameters. Thanks.
Actually I don't it is worth the hassle of testing this. Looks really good to me to close #165. Thanks for this.
Small update to download_hydat to add a parameter
ask
, which will bypass the keypress question and proceed directly to the download of HYDAT ifask=FALSE
. Defaultask=TRUE
makes no change to the existing workflow with the function.Implemented to have an option for bypassing the keypress when using
download_hydat
in another function or other situations when the keypress is not ideal.