search

ropensci / tidyqpcr

quantitative PCR analysis in the tidyverse
https://docs.ropensci.org/tidyqpcr/
Other
50 stars 18 forks source link

Replace superseded "do" function calls #101

Open DimmestP opened 3 years ago

DimmestP commented 3 years ago

From #85 Flic's code review

In calculate_deltadeltacq_bytargetid(), dplyr::do() is SUPERCEDED, perhaps use alternatives suggested in dplyr docs (summarise(), nest_by() and across()) : https://dplyr.tidyverse.org/reference/do.html https://github.com/ewallace/tidyqpcr/blob/master/R/calculate_deltacq.R#L142

ewallace commented 3 years ago

Oh dear, I didn’t realise do() was superseded! That is a very nice function.

Low priority though, if it works?

ewallace commented 2 years ago

I have recently tried to look at this in other situations, and even though do() is superseded I still find it more intuitive in some situations.

ewallace commented 2 years ago

Update: dplyr::summarise now allows return of data frames. That means that we would be able to replace do calls with summarise calls, and update dplyr dependency to v1.0.0 or later.

MichalLauer commented 1 year ago

Hello! Is this issue still relevant?:)

ewallace commented 5 months ago

Hello @MichalLauer - yes this issue is still relevant. I'm just reviewing and updating tidyqpcr. Currently do() still works, and is not generating warnings, but, it's still superseded.

I'm flagging as "help wanted".