search

ropensci / tidyqpcr

quantitative PCR analysis in the tidyverse
https://docs.ropensci.org/tidyqpcr/
Other
50 stars 18 forks source link

Deprecate plot_helpers #178

Closed ewallace closed 2 years ago

ewallace commented 2 years ago

Probably we can deprecate and lose the functions in plot_helpers by using scales::label_log https://scales.r-lib.org/reference/label_log.html

ewallace commented 2 years ago

I decided to make this more robust (not the bleeding-edge scales 1.2.0) by using scales::label_number. In the end we only used the plot_helpers functions a small amount in the vignettes, and the scales package has gotten way better at nice scales over the last couple of years.

Ready to close with pul request.