Response to jooolia 3rd review 2022-06-03

ewallace commented 2 years ago

DRAFT for editing/approval by @DimmestP, after we deal with the pull requests.

--

Thank you for this thorough check, it has helped and we have addressed these:

plot_helpers. Given the minimal use of these functions and that their capabilities are now in the scales package, we removed these in pull request https://github.com/ewallace/tidyqpcr/pull/183
URLs. Fixed in https://github.com/ewallace/tidyqpcr/pull/184
Tests. Addressed in https://github.com/ewallace/tidyqpcr/pull/185
Dplyr joins. Addressed in https://github.com/ewallace/tidyqpcr/pull/182

We hope that's everything? Let us know.

DimmestP commented 2 years ago

@ewallace Everything seems to work perfectly and address the issues raised. I have merged the pull requests and have updated the gh-page. Happy for this to be sent back to Julia.

ewallace commented 2 years ago

@DimmestP thank you for going through those and the feedback. I'll get on to that and submit.

ewallace commented 2 years ago

Responded at https://github.com/ropensci/software-review/issues/470#issuecomment-1149928416

ropensci / tidyqpcr

Response to jooolia 3rd review 2022-06-03 #186