Fix codecov badge - Githubissues

ropensci / tidyqpcr

quantitative PCR analysis in the tidyverse

https://docs.ropensci.org/tidyqpcr/

Other

51 stars 18 forks source link

Fix codecov badge #187

Closed ewallace closed 2 years ago

ewallace commented 2 years ago

I updated the codecov badge in README.md (branch ropensci-accept) to point to the new repo address at https://github.com/ropensci/tidyqpcr/.

@DimmestP might you be able to fix that badge so it works again? Pointing to the main branch?

ewallace commented 2 years ago

I tried to help in sorceror's apprentice mode, in commit 314258b to codemeta.json.

ewallace commented 2 years ago

Apparently it worked already! https://codecov.io/gh/DimmestP/tidyqpcr/branch/main

NOPE - that was the link from the old branch. Still needs fixing.

ewallace commented 2 years ago

Ok. Now a page exists: https://codecov.io/gh/ropensci/tidyqpcr/

And I have learned the function of codemeta.json and updated that automatically in commit a610fbd.

So I believe this to be fixed, and that as soon as there is a commit to main then code coverage will be checked.

ewallace commented 2 years ago

Help: To fix this we need an @ropensci owner to give codecov repository access to ropensci/tidyqpcr

@jeroen is this something you can do?

Link: https://github.com/apps/codecov/installations/167080

jeroen commented 2 years ago

@maelle

maelle commented 2 years ago

:wave: @ewallace!

Ouch, the clunkiness isn't fun, sorry that you experience that and congrats on the peer-review approval!

Here are my notes:

codecov has access to all repositories.
I see it works for https://github.com/ropensci/qualtRics/ (first example I could think of)
How do you use to update the covr score? I'd recommend using the workflow of https://github.com/r-lib/actions/tree/v2/examples, you can run usethis::use_github_action("test-coverage") to get the file, then commit and push it.

Happy to help further as needed.

ewallace commented 2 years ago

Thanks @maelle, this worked!

mpadge commented 2 years ago

@maelle What i did yesterday was to go to codedov where us admins can see a status view of all repos, and that clearly said this repo was just waiting for a push. So this whole process actually demonstrates that at least this piece of our infrastructure "just works" :relieved: - in other words, that codecov itself automatically and perfectly maps the repo transfer, including updating/re-mapping auth tokens. Nice.

ewallace commented 2 years ago

Yes it does just work and I'm drafting an update to the dev guide that I'll ask for review on.