search

ropensci / tokenizers

Fast, Consistent Tokenization of Natural Language Text
https://docs.ropensci.org/tokenizers
Other
184 stars 25 forks source link

Fix #37 and update NEWS #40

Closed Ironholds closed 7 years ago

Ironholds commented 7 years ago

Hmn. This test failure isn't from my change. @lmullen are these new tests?

lmullen commented 7 years ago

@Ironholds Yes, the problem definitely isn't with this PR. The actual problem is here: https://github.com/ropensci/tokenizers/issues/24#issuecomment-291205241

Is this PR okay to merge then? I looked over the changes and they are fine to me.