Closed ChrisMuir closed 6 years ago
Merging #67 into master will decrease coverage by
<.01%
. The diff coverage isn/a
.
@@ Coverage Diff @@
## master #67 +/- ##
==========================================
- Coverage 99.32% 99.31% -0.01%
==========================================
Files 12 12
Lines 443 441 -2
==========================================
- Hits 440 438 -2
Misses 3 3
Impacted Files | Coverage Δ | |
---|---|---|
src/shingle_ngrams.cpp | 100% <ø> (ø) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 964ed40...f18a97d. Read the comment docs.
Thanks, @ChrisMuir.
In cpp function
generate_ngrams_batch()
, variableCharacterVector terms
gets created, anddocuments_list[i_document]
gets dumped to it at the top of each loop. But thendocuments_list[i_document]
ends up getting passed directly to funcgenerate_ngrams_internal()
, soterms
never actually gets used.So I just removed all references to var
terms
in funcgenerate_ngrams_batch()
....no biggie.