ropensci / traits

R package for accessing species trait data from multiple databases
Other
39 stars 14 forks source link

Added 10 new fields to ncbi_byid #102

Closed boopsboops closed 6 years ago

boopsboops commented 6 years ago

Description

I wanted to increase the amount of useful GenBank sequence metadata that was returned by ncbi_byid for use in creating and quality controlling reference libraries for DNA metabarcoding. I added 10 new fields, mostly from the voucher material the DNA sequence came from, and where the study was published:

Related Issue

Fixes issue #101

Example

ncbi_byid(ids="360040093") ncbi_byid(ids=c("360040093","347448433"))

codecov-io commented 6 years ago

Codecov Report

Merging #102 into master will decrease coverage by 0.31%. The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #102      +/-   ##
==========================================
- Coverage   15.76%   15.44%   -0.32%     
==========================================
  Files          17       17              
  Lines         590      602      +12     
==========================================
  Hits           93       93              
- Misses        497      509      +12
Impacted Files Coverage Δ
R/ncbi_byid.R 0% <0%> (ø) :arrow_up:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update dd49d77...7503817. Read the comment docs.

sckott commented 6 years ago

thanks @boopsboops having a look

sckott commented 6 years ago

looks good to me, thanks much!