search

ropensci / traits

R package for accessing species trait data from multiple databases
Other
39 stars 14 forks source link

next cran push #93

Closed sckott closed 5 years ago

sckott commented 7 years ago

@infotroph @dlebauer

i've gone through issues, and next cran push will be this milestone https://github.com/ropensci/traits/milestone/6

so I have a few things to deal with before going to cran - let me know if there's anything that should or shouldn't be on the milestone wrt BETYdb

sckott commented 7 years ago

thoughts @dlebauer @infotroph ^^

infotroph commented 7 years ago

@sckott @dlebauer I think you found all the BETY changes that are ready to go. The remaining issues I see all need more thought (#83, #84) and/or coordination with a larger package cleanup (#38, #39).

Of the other issues in this milestone, looks like httr-->crul (#89) is the only one that might require changes in the BETY code. Does crul provide a drop-in replacement for httr::GET?

sckott commented 7 years ago

it's easy enough to do the conversion to crul - but I think I’ll move it to the next milestone just to speed up this one

infotroph commented 7 years ago

May need to revisit #52 -- include_unchecked only works in some API versions. We should resolve this before release.

dlebauer commented 7 years ago

I think include_unchecked was absent in v0 and new in beta On Tue, Mar 28, 2017 at 3:31 PM Chris Black notifications@github.com wrote:

May need to revisit #52 https://github.com/ropensci/traits/issues/52 -- include_unchecked only works in some API versions. We should resolve this before release.

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/ropensci/traits/issues/93#issuecomment-289894971, or mute the thread https://github.com/notifications/unsubscribe-auth/AAcX58PvuxfgJrvidutbluOWt7VS9lbMks5rqW4IgaJpZM4MkVQS .

dlebauer commented 5 years ago

Hi @sckott when do you think the next version will be released to CRAN? There are some useful changes that Chris did that would be great to have available in the official version.

sckott commented 5 years ago

the next milestone is https://github.com/ropensci/traits/milestone/4 a few of the issues will be very quick, and the others i'll poke at and may move to a future milestone if they will take too long. - so soonish