search

ropensci / vcr

Record and replay HTTP requests
https://docs.ropensci.org/vcr
Other
77 stars 12 forks source link

Encoding YAML Windows #204

Closed maelle closed 3 years ago

maelle commented 3 years ago

Fix #203?

In https://github.com/maelle/vcrencoding/actions/runs/386871714 I am using this branch and things work on Windows

This PR

I wasn't able to find a more elegant way to add the test.

codecov-io commented 3 years ago

Codecov Report

Merging #204 (e31fa18) into master (b2757b8) will increase coverage by 0.02%. The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #204      +/-   ##
==========================================
+ Coverage   79.82%   79.84%   +0.02%     
==========================================
  Files          41       41              
  Lines        1586     1588       +2     
==========================================
+ Hits         1266     1268       +2     
  Misses        320      320
Impacted Files Coverage Δ
R/request_matcher_registry.R 68.00% <100.00%> (ø)
R/serializers-yaml.R 100.00% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update b2757b8...e31fa18. Read the comment docs.

sckott commented 3 years ago

thanks, i'll have a look